Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Fix sync stage handle bug #2344 #2360

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Conversation

jolestar
Copy link
Member

Fix #2344 and enable two ignore tests.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #2360 (4f935ee) into master (9a11cc1) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
+ Coverage   33.27%   33.46%   +0.20%     
==========================================
  Files         477      477              
  Lines       41159    41158       -1     
  Branches    18465    18464       -1     
==========================================
+ Hits        13691    13770      +79     
+ Misses      13683    13462     -221     
- Partials    13785    13926     +141     
Flag Coverage Δ
unittests 33.46% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/sync.rs 27.36% <ø> (+0.09%) ⬆️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 20.11% <0.00%> (-0.53%) ⬇️
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
sync/src/tasks/inner_sync_task.rs 33.06% <0.00%> (ø)
sync/src/tasks/accumulator_sync_task.rs 57.15% <0.00%> (ø)
sync/src/tasks/tests.rs 15.74% <0.00%> (+0.16%) ⬆️
vm/vm-runtime/src/starcoin_vm.rs 29.12% <0.00%> (+0.33%) ⬆️
network-p2p/src/request_responses.rs 30.55% <0.00%> (+0.35%) ⬆️
rpc/client/src/lib.rs 14.79% <0.00%> (+0.47%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a11cc1...4f935ee. Read the comment docs.

@github-actions
Copy link

Benchmark for f97a072

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1588.6±396.68µs 1547.3±142.05µs +2.67%
block_apply/block_apply_10 410.4±1.69ms 416.6±26.09ms -1.49%
block_apply/block_apply_1000 42.6±0.10s 42.6±0.21s 0.00%
get_with_proof/db_store 46.7±1.48µs 44.3±1.01µs +5.42%
get_with_proof/mem_store 35.4±0.81µs 35.6±2.08µs -0.56%
put_and_commit/db_store/1 742.8±33.59µs 739.8±14.20µs +0.41%
put_and_commit/db_store/10 1926.4±185.02µs 1921.0±184.34µs +0.28%
put_and_commit/db_store/100 10.2±0.72ms 10.3±0.66ms -0.97%
put_and_commit/db_store/5 1290.1±94.80µs 1281.3±132.52µs +0.69%
put_and_commit/db_store/50 6.0±0.42ms 5.9±0.40ms +1.69%
put_and_commit/mem_store/1 76.0±4.25µs 76.6±4.47µs -0.78%
put_and_commit/mem_store/10 675.7±34.69µs 678.9±36.18µs -0.47%
put_and_commit/mem_store/100 6.4±0.27ms 6.3±0.22ms +1.59%
put_and_commit/mem_store/5 348.2±19.73µs 345.3±19.22µs +0.84%
put_and_commit/mem_store/50 3.3±0.14ms 3.2±0.15ms +3.13%
query_block/query_block_in(10)_times(100) 3.4±0.09ms 3.4±0.11ms 0.00%
query_block/query_block_in(10)_times(1000) 34.2±0.55ms 34.0±0.95ms +0.59%
query_block/query_block_in(10)_times(10000) 344.9±4.54ms 343.2±3.65ms +0.50%
query_block/query_block_in(1000)_times(100) 1377.7±19.20µs 1368.1±12.46µs +0.70%
query_block/query_block_in(1000)_times(1000) 14.4±0.26ms 13.9±0.14ms +3.60%
query_block/query_block_in(1000)_times(10000) 142.0±1.91ms 139.6±2.01ms +1.72%
storage_transaction 20.6±0.89ms 21.0±0.55ms -1.90%
vm/transaction_execution/1 390.6±5.21ms 396.3±2.72ms -1.44%
vm/transaction_execution/10 127.0±0.83ms 127.2±1.30ms -0.16%
vm/transaction_execution/20 120.5±1.14ms 120.6±2.66ms -0.08%
vm/transaction_execution/5 154.2±2.11ms 155.1±0.97ms -0.58%
vm/transaction_execution/50 135.0±1.32ms 135.0±1.37ms 0.00%

@github-actions
Copy link

Benchmark for 88d5210

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1261.3±58.47µs 1266.6±44.78µs -0.42%
block_apply/block_apply_10 368.9±1.52ms 366.2±0.98ms +0.74%
block_apply/block_apply_1000 38.5±0.25s 38.6±0.16s -0.26%
get_with_proof/db_store 42.2±0.53µs 43.1±2.47µs -2.09%
get_with_proof/mem_store 33.0±0.54µs 32.8±0.44µs +0.61%
put_and_commit/db_store/1 588.3±84.96µs 662.3±708.35µs -11.17%
put_and_commit/db_store/10 1603.4±184.14µs 1564.9±107.45µs +2.46%
put_and_commit/db_store/100 9.3±0.36ms 9.4±0.34ms -1.06%
put_and_commit/db_store/5 1053.1±76.41µs 1162.4±553.51µs -9.40%
put_and_commit/db_store/50 5.3±0.22ms 5.4±0.27ms -1.85%
put_and_commit/mem_store/1 72.6±4.23µs 72.8±3.67µs -0.27%
put_and_commit/mem_store/10 643.7±30.42µs 647.5±30.32µs -0.59%
put_and_commit/mem_store/100 6.0±0.20ms 6.0±0.20ms 0.00%
put_and_commit/mem_store/5 331.2±17.85µs 330.1±16.21µs +0.33%
put_and_commit/mem_store/50 3.1±0.12ms 3.1±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 3.3±0.07ms 3.2±0.06ms +3.13%
query_block/query_block_in(10)_times(1000) 32.4±0.73ms 32.1±0.82ms +0.93%
query_block/query_block_in(10)_times(10000) 323.5±5.97ms 321.0±4.47ms +0.78%
query_block/query_block_in(1000)_times(100) 1312.2±8.04µs 1320.3±6.91µs -0.61%
query_block/query_block_in(1000)_times(1000) 13.1±0.14ms 13.1±0.06ms 0.00%
query_block/query_block_in(1000)_times(10000) 130.4±0.65ms 130.9±0.64ms -0.38%
storage_transaction 14.7±0.56ms 14.2±1.35ms +3.52%
vm/transaction_execution/1 378.1±2.00ms 381.9±3.41ms -1.00%
vm/transaction_execution/10 123.0±1.24ms 123.8±0.77ms -0.65%
vm/transaction_execution/20 114.3±0.62ms 115.3±0.66ms -0.87%
vm/transaction_execution/5 148.8±0.61ms 150.7±0.71ms -1.26%
vm/transaction_execution/50 129.6±0.67ms 131.0±1.10ms -1.07%

@tiangong3624749 tiangong3624749 merged commit 17201f4 into master Mar 31, 2021
@tiangong3624749 tiangong3624749 deleted the fix/sync_state_handle branch March 31, 2021 10:04
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sync] sync task stage handle bug.
2 participants