Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network-rpc] structure network rpc request log. #2368

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Apr 1, 2021

先用空格切分记录了一下 network rpc 的日志,增加了 rpc 消耗的时间。

等确定 #2359 的方案了再修改。

@jolestar jolestar requested review from ssyuan and sanlee42 April 1, 2021 04:46
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2368 (71576a0) into master (ae622b2) will increase coverage by 0.05%.
The diff coverage is 14.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2368      +/-   ##
==========================================
+ Coverage   33.37%   33.41%   +0.05%     
==========================================
  Files         477      478       +1     
  Lines       41121    41152      +31     
  Branches    18432    18432              
==========================================
+ Hits        13718    13748      +30     
+ Misses      13576    13530      -46     
- Partials    13827    13874      +47     
Flag Coverage Δ
unittests 33.41% <14.29%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network-p2p/src/request_responses.rs 30.61% <14.29%> (+0.07%) ⬆️
vm/types/src/transaction/authenticator.rs 43.71% <0.00%> (-5.87%) ⬇️
sync/src/verified_rpc_client.rs 18.08% <0.00%> (-2.11%) ⬇️
account/api/src/service.rs 9.80% <0.00%> (-0.73%) ⬇️
rpc/client/src/lib.rs 14.22% <0.00%> (-0.10%) ⬇️
account/src/account.rs 36.21% <0.00%> (ø)
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
account/api/src/message.rs 0.00% <0.00%> (ø)
account/src/account_manager.rs 42.77% <0.00%> (ø)
rpc/server/src/module/account_rpc.rs 16.79% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae622b2...71576a0. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Benchmark for 87446d2

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1188.4±65.77µs 1203.3±65.83µs -1.24%
block_apply/block_apply_10 359.7±2.24ms 369.8±23.53ms -2.73%
block_apply/block_apply_1000 37.8±0.10s 37.7±0.13s +0.27%
get_with_proof/db_store 42.3±0.64µs 43.3±1.30µs -2.31%
get_with_proof/mem_store 32.4±0.53µs 32.4±0.68µs 0.00%
put_and_commit/db_store/1 537.9±29.36µs 524.0±22.54µs +2.65%
put_and_commit/db_store/10 1568.6±76.61µs 1576.8±73.57µs -0.52%
put_and_commit/db_store/100 9.3±0.42ms 9.1±0.40ms +2.20%
put_and_commit/db_store/5 998.3±88.39µs 1017.8±214.17µs -1.92%
put_and_commit/db_store/50 5.2±0.26ms 5.2±0.27ms 0.00%
put_and_commit/mem_store/1 73.1±3.78µs 72.6±3.72µs +0.69%
put_and_commit/mem_store/10 643.6±37.27µs 637.7±33.27µs +0.93%
put_and_commit/mem_store/100 6.1±0.54ms 6.1±0.55ms 0.00%
put_and_commit/mem_store/5 326.6±17.13µs 329.5±17.69µs -0.88%
put_and_commit/mem_store/50 3.0±0.12ms 3.0±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 3.3±0.09ms 3.2±0.05ms +3.13%
query_block/query_block_in(10)_times(1000) 32.5±0.88ms 32.8±0.68ms -0.91%
query_block/query_block_in(10)_times(10000) 326.0±3.73ms 328.0±1.73ms -0.61%
query_block/query_block_in(1000)_times(100) 1318.7±9.34µs 1350.2±9.07µs -2.33%
query_block/query_block_in(1000)_times(1000) 13.3±0.10ms 13.3±0.05ms 0.00%
query_block/query_block_in(1000)_times(10000) 135.0±0.51ms 134.9±0.52ms +0.07%
storage_transaction 12.9±3.39ms 12.6±0.67ms +2.38%
vm/transaction_execution/1 375.7±1.30ms 380.0±2.26ms -1.13%
vm/transaction_execution/10 121.1±0.24ms 121.7±0.62ms -0.49%
vm/transaction_execution/20 112.6±0.60ms 113.3±0.59ms -0.62%
vm/transaction_execution/5 147.2±0.71ms 148.3±0.61ms -0.74%
vm/transaction_execution/50 128.4±0.52ms 129.3±0.48ms -0.70%

@jolestar jolestar merged commit bf3c167 into master Apr 1, 2021
@jolestar jolestar deleted the network_rpc_access_log branch April 1, 2021 06:42
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants