Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block relayer]is_nearly_synced. #2394

Merged
merged 2 commits into from
Apr 8, 2021
Merged

[block relayer]is_nearly_synced. #2394

merged 2 commits into from
Apr 8, 2021

Conversation

tiangong3624749
Copy link
Contributor

No description provided.

@tiangong3624749 tiangong3624749 requested a review from jolestar April 8, 2021 05:57
block-relayer/src/block_relayer.rs Outdated Show resolved Hide resolved
types/src/sync_status.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Benchmark for f018256

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1183.3±37.80µs 1208.2±68.72µs -2.06%
block_apply/block_apply_10 363.2±2.39ms 363.6±2.80ms -0.11%
block_apply/block_apply_1000 37.6±0.29s 37.5±0.24s +0.27%
get_with_proof/db_store 42.8±1.35µs 41.3±0.89µs +3.63%
get_with_proof/mem_store 33.4±0.39µs 32.3±0.48µs +3.41%
put_and_commit/db_store/1 550.4±33.23µs 564.6±24.28µs -2.52%
put_and_commit/db_store/10 1510.4±79.43µs 1561.8±65.20µs -3.29%
put_and_commit/db_store/100 8.6±0.46ms 8.9±0.46ms -3.37%
put_and_commit/db_store/5 988.7±90.21µs 998.7±70.69µs -1.00%
put_and_commit/db_store/50 4.9±0.38ms 5.0±0.21ms -2.00%
put_and_commit/mem_store/1 71.4±3.71µs 70.1±3.69µs +1.85%
put_and_commit/mem_store/10 639.6±30.69µs 635.0±40.75µs +0.72%
put_and_commit/mem_store/100 6.0±0.52ms 6.0±0.54ms 0.00%
put_and_commit/mem_store/5 327.2±16.70µs 325.1±17.33µs +0.65%
put_and_commit/mem_store/50 3.0±0.13ms 3.1±0.12ms -3.23%
query_block/query_block_in(10)_times(100) 3.2±0.06ms 3.2±0.11ms 0.00%
query_block/query_block_in(10)_times(1000) 32.1±0.72ms 32.0±0.79ms +0.31%
query_block/query_block_in(10)_times(10000) 320.3±3.75ms 323.3±5.73ms -0.93%
query_block/query_block_in(1000)_times(100) 1277.7±5.77µs 1292.3±10.50µs -1.13%
query_block/query_block_in(1000)_times(1000) 12.7±0.10ms 12.9±0.09ms -1.55%
query_block/query_block_in(1000)_times(10000) 128.7±1.12ms 129.7±0.56ms -0.77%
storage_transaction 15.5±0.98ms 15.1±0.85ms +2.65%
vm/transaction_execution/1 375.5±2.85ms 376.4±3.85ms -0.24%
vm/transaction_execution/10 120.6±0.53ms 121.8±1.69ms -0.99%
vm/transaction_execution/20 111.9±0.79ms 112.7±0.62ms -0.71%
vm/transaction_execution/5 146.1±1.31ms 146.9±0.71ms -0.54%
vm/transaction_execution/50 127.4±0.91ms 128.2±0.79ms -0.62%

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2394 (ed3d650) into master (aa1835f) will increase coverage by 0.06%.
The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   33.05%   33.11%   +0.06%     
==========================================
  Files         478      478              
  Lines       41170    41340     +170     
  Branches    18451    18544      +93     
==========================================
+ Hits        13605    13685      +80     
+ Misses      13879    13840      -39     
- Partials    13686    13815     +129     
Flag Coverage Δ
unittests 33.11% <33.34%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
block-relayer/src/block_relayer.rs 27.05% <33.34%> (-0.52%) ⬇️
types/src/sync_status.rs 44.45% <33.34%> (-2.61%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
types/src/peer_info.rs 50.00% <0.00%> (-8.87%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
network/api/src/tests.rs 24.20% <0.00%> (-5.80%) ⬇️
network-p2p/src/protocol/event.rs 30.00% <0.00%> (-3.33%) ⬇️
sync/src/tasks/mock.rs 49.10% <0.00%> (-2.78%) ⬇️
cmd/starcoin/src/dev/tests.rs 12.31% <0.00%> (-2.77%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1835f...ed3d650. Read the comment docs.

@tiangong3624749 tiangong3624749 requested a review from jolestar April 8, 2021 08:12
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Benchmark for ce1fe50

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1270.9±669.65µs 1211.6±60.36µs +4.89%
block_apply/block_apply_10 359.8±4.02ms 361.4±2.26ms -0.44%
block_apply/block_apply_1000 38.3±0.09s 38.1±0.11s +0.52%
get_with_proof/db_store 43.0±0.76µs 42.7±0.96µs +0.70%
get_with_proof/mem_store 33.1±0.85µs 32.9±0.69µs +0.61%
put_and_commit/db_store/1 537.5±27.40µs 529.8±29.90µs +1.45%
put_and_commit/db_store/10 1594.3±60.65µs 1595.4±70.52µs -0.07%
put_and_commit/db_store/100 9.1±0.41ms 9.2±0.45ms -1.09%
put_and_commit/db_store/5 1030.2±151.41µs 1035.8±96.77µs -0.54%
put_and_commit/db_store/50 5.1±0.24ms 5.2±0.22ms -1.92%
put_and_commit/mem_store/1 70.7±3.83µs 71.6±3.98µs -1.26%
put_and_commit/mem_store/10 640.6±30.09µs 638.6±31.12µs +0.31%
put_and_commit/mem_store/100 6.0±0.60ms 6.1±0.54ms -1.64%
put_and_commit/mem_store/5 327.0±18.14µs 330.3±17.87µs -1.00%
put_and_commit/mem_store/50 3.0±0.12ms 3.1±0.13ms -3.23%
query_block/query_block_in(10)_times(100) 3.2±0.07ms 3.2±0.10ms 0.00%
query_block/query_block_in(10)_times(1000) 32.3±0.90ms 32.3±0.50ms 0.00%
query_block/query_block_in(10)_times(10000) 326.2±4.34ms 322.1±7.06ms +1.27%
query_block/query_block_in(1000)_times(100) 1335.7±14.25µs 1298.0±5.74µs +2.90%
query_block/query_block_in(1000)_times(1000) 13.4±0.09ms 13.1±0.13ms +2.29%
query_block/query_block_in(1000)_times(10000) 132.9±0.59ms 130.6±0.75ms +1.76%
storage_transaction 14.3±1.47ms 15.8±1.48ms -9.49%
vm/transaction_execution/1 369.3±2.07ms 379.6±2.24ms -2.71%
vm/transaction_execution/10 119.8±1.52ms 121.7±0.59ms -1.56%
vm/transaction_execution/20 111.2±1.23ms 114.3±1.05ms -2.71%
vm/transaction_execution/5 145.3±0.68ms 147.3±1.26ms -1.36%
vm/transaction_execution/50 129.1±1.07ms 128.8±1.57ms +0.23%

@tiangong3624749 tiangong3624749 merged commit 5648d19 into master Apr 8, 2021
@tiangong3624749 tiangong3624749 deleted the is_nearly_synced branch April 8, 2021 08:49
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
* [block relayer]is_nearly_synced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants