Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Fix config compat bug, add new config option do not break compat #2439

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

jolestar
Copy link
Member

No description provided.

@jolestar jolestar requested a review from sanlee42 April 23, 2021 02:00
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2439 (db0338f) into master (aa8b91a) will decrease coverage by 0.88%.
The diff coverage is 13.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
- Coverage   33.47%   32.60%   -0.87%     
==========================================
  Files         486      491       +5     
  Lines       42001    42295     +294     
  Branches    18951    19086     +135     
==========================================
- Hits        14057    13786     -271     
- Misses      13568    14518     +950     
+ Partials    14376    13991     -385     
Flag Coverage Δ
unittests 32.60% <13.43%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/lib.rs 27.06% <0.00%> (-0.43%) ⬇️
config/src/sync_config.rs 36.85% <ø> (-15.78%) ⬇️
config/src/tests.rs 28.00% <ø> (ø)
consensus/src/consensus.rs 43.75% <0.00%> (-15.26%) ⬇️
consensus/src/consensus_test.rs 65.31% <ø> (ø)
node/src/node.rs 13.80% <0.00%> (-0.39%) ⬇️
stratum/src/rpc.rs 2.46% <2.46%> (ø)
stratum/src/lib.rs 11.12% <11.12%> (ø)
stratum/src/stratum.rs 14.29% <14.29%> (ø)
config/src/stratum_config.rs 37.94% <37.94%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f3851...db0338f. Read the comment docs.

@github-actions
Copy link

Benchmark for 4516d77

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.2±0.19ms 2.0±0.11ms +10.00%
block_apply/block_apply_10 372.6±3.01ms 388.3±8.35ms -4.04%
block_apply/block_apply_1000 38.4±0.77s 41.4±1.54s -7.25%
get_with_proof/db_store 39.5±0.34µs 38.6±0.31µs +2.33%
get_with_proof/mem_store 32.7±0.36µs 31.8±0.33µs +2.83%
put_and_commit/db_store/1 1161.3±70.07µs 1237.9±90.84µs -6.19%
put_and_commit/db_store/10 2.4±0.60ms 2.3±0.52ms +4.35%
put_and_commit/db_store/100 9.5±0.89ms 9.5±1.01ms 0.00%
put_and_commit/db_store/5 1912.5±240.06µs 1913.0±225.98µs -0.03%
put_and_commit/db_store/50 5.9±0.90ms 5.6±1.02ms +5.36%
put_and_commit/mem_store/1 63.4±5.63µs 63.1±5.70µs +0.48%
put_and_commit/mem_store/10 589.4±46.88µs 586.8±47.05µs +0.44%
put_and_commit/mem_store/100 5.8±0.82ms 5.7±0.82ms +1.75%
put_and_commit/mem_store/5 299.5±25.28µs 297.1±24.40µs +0.81%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.7±0.08ms 2.6±0.07ms +3.85%
query_block/query_block_in(10)_times(1000) 26.3±0.55ms 26.3±0.61ms 0.00%
query_block/query_block_in(10)_times(10000) 264.5±6.49ms 264.9±3.84ms -0.15%
query_block/query_block_in(1000)_times(100) 928.8±5.19µs 906.9±7.25µs +2.41%
query_block/query_block_in(1000)_times(1000) 9.1±0.05ms 9.1±0.04ms 0.00%
query_block/query_block_in(1000)_times(10000) 91.3±0.58ms 90.6±0.37ms +0.77%
storage_transaction 47.4±6.07ms 44.2±3.91ms +7.24%
vm/transaction_execution/1 303.5±3.05ms 303.4±0.97ms +0.03%
vm/transaction_execution/10 102.1±0.85ms 102.2±0.81ms -0.10%
vm/transaction_execution/20 96.3±0.37ms 96.6±0.35ms -0.31%
vm/transaction_execution/5 122.1±1.32ms 122.4±1.28ms -0.25%
vm/transaction_execution/50 111.8±0.35ms 112.3±0.62ms -0.45%

@github-actions
Copy link

Benchmark for 5cc5d55

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.6±0.10ms 2.6±0.40ms 0.00%
block_apply/block_apply_10 447.6±11.72ms 441.8±8.90ms +1.31%
block_apply/block_apply_1000 45.3±0.54s 45.1±0.57s +0.44%
get_with_proof/db_store 38.3±0.28µs 38.5±0.35µs -0.52%
get_with_proof/mem_store 31.4±0.24µs 31.7±0.68µs -0.95%
put_and_commit/db_store/1 1513.9±90.76µs 1489.2±76.02µs +1.66%
put_and_commit/db_store/10 2.6±0.43ms 2.6±0.36ms 0.00%
put_and_commit/db_store/100 9.8±1.23ms 9.7±1.22ms +1.03%
put_and_commit/db_store/5 2.1±0.19ms 2.1±0.17ms 0.00%
put_and_commit/db_store/50 5.9±0.84ms 5.9±0.77ms 0.00%
put_and_commit/mem_store/1 62.9±5.59µs 63.3±6.11µs -0.63%
put_and_commit/mem_store/10 582.1±45.00µs 588.2±46.84µs -1.04%
put_and_commit/mem_store/100 5.7±0.80ms 5.8±0.84ms -1.72%
put_and_commit/mem_store/5 295.6±24.01µs 296.2±24.22µs -0.20%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.6±0.06ms 2.6±0.05ms 0.00%
query_block/query_block_in(10)_times(1000) 26.5±0.44ms 26.5±0.33ms 0.00%
query_block/query_block_in(10)_times(10000) 266.9±4.45ms 265.3±4.15ms +0.60%
query_block/query_block_in(1000)_times(100) 925.9±5.13µs 909.8±6.29µs +1.77%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.1±0.10ms +1.10%
query_block/query_block_in(1000)_times(10000) 92.7±0.47ms 90.7±0.88ms +2.21%
storage_transaction 58.1±4.47ms 56.2±3.35ms +3.38%
vm/transaction_execution/1 304.8±1.34ms 303.5±1.00ms +0.43%
vm/transaction_execution/10 102.2±0.30ms 102.3±0.83ms -0.10%
vm/transaction_execution/20 96.8±0.33ms 96.6±0.76ms +0.21%
vm/transaction_execution/5 122.2±0.80ms 122.0±0.40ms +0.16%
vm/transaction_execution/50 112.4±0.41ms 112.3±0.25ms +0.09%

@jolestar jolestar merged commit 040bbad into master Apr 23, 2021
@jolestar jolestar deleted the fix/config_compat branch April 23, 2021 04:32
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…mpat (starcoinorg#2439)

* [config] Fix config compat bug, add new config option do not break compat.

* [test] fix auto return test script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants