Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] bug fix for stdlib upgrade #2461

Merged
merged 4 commits into from
Apr 29, 2021
Merged

[stdlib] bug fix for stdlib upgrade #2461

merged 4 commits into from
Apr 29, 2021

Conversation

guangyuz
Copy link
Contributor

@guangyuz guangyuz commented Apr 28, 2021 •
edited
Loading

  • init script can be added into incremental package, see 'cargo run -p stdlib -- -h'
  • add upgrade_module_proposal_v2_cmd and upgrade_module_queue_v2_cmd
  • update upgrade module dev document
  • stdlib v2 is generated for testing, it's expected to be removed and re-generated in future

@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #2461 (db0ad80) into master (4b439f4) will decrease coverage by 0.20%.
The diff coverage is 8.34%.

❗ Current head db0ad80 differs from pull request most recent head 73976c2. Consider uploading reports for the commit 73976c2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   33.58%   33.39%   -0.19%     
==========================================
  Files         493      492       -1     
  Lines       42859    42919      +60     
  Branches    19425    19470      +45     
==========================================
- Hits        14391    14329      -62     
- Misses      13562    13798     +236     
+ Partials    14906    14792     -114
Flag Coverage Δ
unittests 33.39% <8.34%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
executor/src/stdlib_test/module_upgrade_test.rs 16.09% <5.36%> (-2.09%) ⬇️
vm/transaction-builder/src/lib.rs 26.87% <10.82%> (-3.03%) ⬇️
cmd/starcoin/src/dev/tests.rs 14.91% <33.34%> (ø)
block-relayer/src/metrics.rs 0.00% <0.00%> (-38.46%) ⬇️
sync/api/src/lib.rs 9.31% <0.00%> (-20.93%) ⬇️
block-relayer/src/block_relayer.rs 15.73% <0.00%> (-11.32%) ⬇️
types/src/system_events.rs 87.88% <0.00%> (-6.06%) ⬇️
types/src/sync_status.rs 55.56% <0.00%> (-4.76%) ⬇️
...ync/src/block_connector/block_connector_service.rs 27.59% <0.00%> (-4.59%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e5cee...73976c2. Read the comment docs.

@github-actions
Copy link

Benchmark for a15defe

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.5±0.11ms 2.7±0.18ms -7.41%
block_apply/block_apply_10 461.4±13.26ms 445.3±9.56ms +3.62%
block_apply/block_apply_1000 47.9±2.50s 46.5±1.55s +3.01%
get_with_proof/db_store 38.2±0.30µs 38.2±0.39µs 0.00%
get_with_proof/mem_store 31.8±0.32µs 31.6±0.37µs +0.63%
put_and_commit/db_store/1 1943.5±228.06µs 1706.9±145.43µs +13.86%
put_and_commit/db_store/10 2.7±0.28ms 2.8±0.41ms -3.57%
put_and_commit/db_store/100 10.0±1.01ms 9.7±1.02ms +3.09%
put_and_commit/db_store/5 2.2±0.22ms 2.0±0.13ms +10.00%
put_and_commit/db_store/50 5.8±0.62ms 6.0±0.71ms -3.33%
put_and_commit/mem_store/1 63.6±5.61µs 63.1±5.56µs +0.79%
put_and_commit/mem_store/10 591.5±46.56µs 587.5±46.72µs +0.68%
put_and_commit/mem_store/100 5.8±0.81ms 5.7±0.81ms +1.75%
put_and_commit/mem_store/5 300.5±24.46µs 297.2±24.48µs +1.11%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.7±0.06ms 2.7±0.04ms 0.00%
query_block/query_block_in(10)_times(1000) 26.5±0.70ms 26.3±0.54ms +0.76%
query_block/query_block_in(10)_times(10000) 265.8±4.62ms 268.0±3.09ms -0.82%
query_block/query_block_in(1000)_times(100) 911.3±4.29µs 913.7±4.62µs -0.26%
query_block/query_block_in(1000)_times(1000) 9.1±0.04ms 9.1±0.05ms 0.00%
query_block/query_block_in(1000)_times(10000) 90.8±0.56ms 91.3±0.26ms -0.55%
storage_transaction 70.2±5.79ms 65.1±5.63ms +7.83%
vm/transaction_execution/1 306.8±0.48ms 308.0±0.89ms -0.39%
vm/transaction_execution/10 103.4±0.49ms 103.8±0.95ms -0.39%
vm/transaction_execution/20 97.8±0.20ms 97.4±0.24ms +0.41%
vm/transaction_execution/5 123.4±0.35ms 123.9±1.03ms -0.40%
vm/transaction_execution/50 113.1±0.87ms 113.2±0.57ms -0.09%

jolestar
jolestar approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是应该把 #2450 合并进来再发 v2?

guangyuz added 4 commits April 29, 2021 15:53
@guangyuz
[stdlib] bug fix for stdlib upgrade
6dc1bba 
  - init script can added into incremental package, see 'cargo run -p stdlib -- -h'
  - add upgrade_module_proposal_v2_cmd and upgrade_module_queue_v2_cmd
  - update upgrade module dev document
  - stdlib v2 is generated for testing, it's expected to be removed and re-generated in future
@guangyuz
fix unit test
4d4209e
@guangyuz
fix test
e22716b
@guangyuz
re-generate stdlib after rebase, doc, and fix test
73976c2
@github-actions
Copy link

Benchmark for 566fcd3

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.4±0.16ms 2.3±0.11ms +4.35%
block_apply/block_apply_10 442.2±21.55ms 439.2±14.46ms +0.68%
block_apply/block_apply_1000 43.6±0.44s 43.1±0.45s +1.16%
get_with_proof/db_store 38.6±0.32µs 38.4±0.36µs +0.52%
get_with_proof/mem_store 31.8±0.30µs 31.7±0.29µs +0.32%
put_and_commit/db_store/1 1390.9±106.13µs 1393.5±121.49µs -0.19%
put_and_commit/db_store/10 2.5±0.85ms 2.5±0.72ms 0.00%
put_and_commit/db_store/100 9.6±1.39ms 24.5±11.15ms -60.82%
put_and_commit/db_store/5 1987.4±219.50µs 2.0±0.25ms -0.63%
put_and_commit/db_store/50 5.8±1.36ms 5.9±1.21ms -1.69%
put_and_commit/mem_store/1 63.5±5.96µs 63.1±5.57µs +0.63%
put_and_commit/mem_store/10 587.5±45.99µs 589.1±48.17µs -0.27%
put_and_commit/mem_store/100 5.7±0.81ms 5.8±0.82ms -1.72%
put_and_commit/mem_store/5 296.8±24.39µs 297.9±24.08µs -0.37%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.7±0.09ms 2.8±0.05ms -3.57%
query_block/query_block_in(10)_times(1000) 27.8±0.60ms 27.5±0.87ms +1.09%
query_block/query_block_in(10)_times(10000) 278.8±4.94ms 277.4±5.92ms +0.50%
query_block/query_block_in(1000)_times(100) 915.7±7.57µs 942.6±4.89µs -2.85%
query_block/query_block_in(1000)_times(1000) 9.1±0.04ms 9.4±0.04ms -3.19%
query_block/query_block_in(1000)_times(10000) 92.3±0.44ms 94.1±0.41ms -1.91%
storage_transaction 53.0±5.82ms 51.2±5.99ms +3.52%
vm/transaction_execution/1 312.9±1.03ms 314.6±3.97ms -0.54%
vm/transaction_execution/10 105.3±0.43ms 105.8±0.95ms -0.47%
vm/transaction_execution/20 101.2±5.45ms 99.6±0.30ms +1.61%
vm/transaction_execution/5 126.0±0.61ms 126.7±1.83ms -0.55%
vm/transaction_execution/50 116.2±2.90ms 115.2±0.54ms +0.87%

@guangyuz guangyuz merged commit a67b410 into master Apr 29, 2021
@guangyuz guangyuz deleted the fix/cmd branch April 29, 2021 08:59
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
@guangyuz @naughtyvenom
[stdlib] bug fix for stdlib upgrade (starcoinorg#2461)
a823e15 
* init script can be added into incremental package, see 'cargo run -p stdlib -- -h'
* add upgrade_module_proposal_v2_cmd and upgrade_module_queue_v2_cmd
* update upgrade module dev document
* stdlib v2 is generated for testing, it's expected to be removed and re-generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guangyuz @jolestar