Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt identifier #2490

Merged
merged 5 commits into from
May 11, 2021
Merged

Receipt identifier #2490

merged 5 commits into from
May 11, 2021

Conversation

nanne007
Copy link
Member

  • account show display receipt identifier.
  • remove dev execute.
  • add account execute-script.
  • update doc to sync with the change.

@nanne007 nanne007 requested review from jolestar and guangyuz May 10, 2021 08:49
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2490 (25aec1b) into master (1a5731a) will increase coverage by 0.05%.
The diff coverage is 36.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
+ Coverage   33.12%   33.17%   +0.05%     
==========================================
  Files         497      498       +1     
  Lines       43078    43128      +50     
  Branches    19511    19535      +24     
==========================================
+ Hits        14266    14303      +37     
+ Misses      14154    14108      -46     
- Partials    14658    14717      +59     
Flag Coverage Δ
unittests 33.17% <36.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
types/src/lib.rs 100.00% <ø> (ø)
types/src/receipt_identifier.rs 36.00% <36.00%> (ø)
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
miner/src/generate_block_event_pacemaker.rs 41.87% <0.00%> (-2.32%) ⬇️
commons/accumulator/src/inmemory/mod.rs 62.14% <0.00%> (-1.94%) ⬇️
network-rpc/src/rpc.rs 17.95% <0.00%> (-1.92%) ⬇️
sync/src/tasks/mock.rs 47.65% <0.00%> (-1.76%) ⬇️
types/src/sync_status.rs 60.32% <0.00%> (-1.58%) ⬇️
network/src/service.rs 31.94% <0.00%> (-1.48%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5731a...25aec1b. Read the comment docs.

@github-actions
Copy link

Benchmark for e1a55d5

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.4±0.16ms 2.4±0.12ms 0.00%
block_apply/block_apply_10 468.6±7.49ms 471.6±5.11ms -0.64%
block_apply/block_apply_1000 48.3±0.44s 49.1±1.04s -1.63%
get_with_proof/db_store 38.4±0.37µs 38.5±0.39µs -0.26%
get_with_proof/mem_store 31.5±0.41µs 31.5±0.26µs 0.00%
put_and_commit/db_store/1 1635.0±84.91µs 1615.0±104.47µs +1.24%
put_and_commit/db_store/10 2.7±0.37ms 2.6±0.46ms +3.85%
put_and_commit/db_store/100 9.7±1.12ms 9.6±0.88ms +1.04%
put_and_commit/db_store/5 2.1±0.20ms 2.1±0.16ms 0.00%
put_and_commit/db_store/50 5.9±0.81ms 5.8±0.77ms +1.72%
put_and_commit/mem_store/1 63.1±5.95µs 63.5±5.76µs -0.63%
put_and_commit/mem_store/10 585.9±47.83µs 590.6±47.12µs -0.80%
put_and_commit/mem_store/100 5.7±0.35ms 5.8±0.83ms -1.72%
put_and_commit/mem_store/5 295.9±25.27µs 300.3±26.16µs -1.47%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.06ms 2.9±0.09ms +3.45%
query_block/query_block_in(10)_times(1000) 30.1±0.56ms 29.8±0.43ms +1.01%
query_block/query_block_in(10)_times(10000) 301.4±6.44ms 296.9±3.14ms +1.52%
query_block/query_block_in(1000)_times(100) 941.8±4.14µs 935.5±2.97µs +0.67%
query_block/query_block_in(1000)_times(1000) 9.4±0.05ms 9.2±0.05ms +2.17%
query_block/query_block_in(1000)_times(10000) 94.7±0.50ms 92.3±0.54ms +2.60%
storage_transaction 55.2±5.44ms 53.2±3.13ms +3.76%
vm/transaction_execution/1 339.3±2.39ms 338.9±3.64ms +0.12%
vm/transaction_execution/10 114.0±1.82ms 113.5±0.81ms +0.44%
vm/transaction_execution/20 107.1±1.39ms 106.7±0.99ms +0.37%
vm/transaction_execution/5 136.5±1.55ms 135.9±0.51ms +0.44%
vm/transaction_execution/50 122.2±0.71ms 122.0±0.48ms +0.16%

@nanne007 nanne007 force-pushed the receipt_identifier branch from 8c56262 to 6d90249 Compare May 11, 2021 01:18
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,account transfer 命令的 receiver 参数也需要支持一下 receipt identifier 吧?

@github-actions
Copy link

Benchmark for 9f537f9

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.5±0.13ms 2.5±0.17ms 0.00%
block_apply/block_apply_10 475.0±8.59ms 464.4±4.01ms +2.28%
block_apply/block_apply_1000 47.6±0.49s 49.1±1.03s -3.05%
get_with_proof/db_store 37.9±0.30µs 38.5±0.34µs -1.56%
get_with_proof/mem_store 31.3±0.25µs 31.6±0.25µs -0.95%
put_and_commit/db_store/1 1585.6±121.25µs 1617.3±79.05µs -1.96%
put_and_commit/db_store/10 2.6±0.40ms 2.6±0.36ms 0.00%
put_and_commit/db_store/100 9.9±0.92ms 9.6±0.81ms +3.13%
put_and_commit/db_store/5 2.1±0.19ms 2.1±0.18ms 0.00%
put_and_commit/db_store/50 6.0±0.67ms 5.8±0.69ms +3.45%
put_and_commit/mem_store/1 63.0±5.61µs 62.9±5.50µs +0.16%
put_and_commit/mem_store/10 584.7±48.35µs 588.6±45.84µs -0.66%
put_and_commit/mem_store/100 5.7±0.84ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 295.1±24.51µs 296.8±23.93µs -0.57%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.09ms 3.0±0.05ms 0.00%
query_block/query_block_in(10)_times(1000) 29.5±0.30ms 29.9±0.53ms -1.34%
query_block/query_block_in(10)_times(10000) 299.3±7.02ms 298.0±5.47ms +0.44%
query_block/query_block_in(1000)_times(100) 908.8±3.66µs 929.3±9.73µs -2.21%
query_block/query_block_in(1000)_times(1000) 9.1±0.04ms 9.3±0.07ms -2.15%
query_block/query_block_in(1000)_times(10000) 93.6±0.86ms 92.9±0.51ms +0.75%
storage_transaction 66.9±5.66ms 63.0±5.11ms +6.19%
vm/transaction_execution/1 336.7±1.01ms 338.3±1.04ms -0.47%
vm/transaction_execution/10 113.4±0.46ms 114.5±1.51ms -0.96%
vm/transaction_execution/20 106.9±1.43ms 107.7±0.66ms -0.74%
vm/transaction_execution/5 136.0±0.59ms 136.4±0.38ms -0.29%
vm/transaction_execution/50 122.2±0.76ms 123.5±3.02ms -1.05%

@nanne007 nanne007 merged commit e28631a into master May 11, 2021
@nanne007 nanne007 deleted the receipt_identifier branch May 11, 2021 03:30
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
* impl receipt identifier

* cli: remove dev execute and add account execute-script

* fix test

* transfer cmd accept receipt

* unify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants