-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receipt identifier #2490
Receipt identifier #2490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2490 +/- ##
==========================================
+ Coverage 33.12% 33.17% +0.05%
==========================================
Files 497 498 +1
Lines 43078 43128 +50
Branches 19511 19535 +24
==========================================
+ Hits 14266 14303 +37
+ Misses 14154 14108 -46
- Partials 14658 14717 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for e1a55d5Click to view benchmark
|
8c56262
to
6d90249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,account transfer 命令的 receiver 参数也需要支持一下 receipt identifier 吧?
Benchmark for 9f537f9Click to view benchmark
|
* impl receipt identifier * cli: remove dev execute and add account execute-script * fix test * transfer cmd accept receipt * unify
dev execute
.account execute-script
.