Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Rework on network metrics. #2967

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

jolestar
Copy link
Member

重构 block relay metrics

  1. 将多个 txns_filled metris 合并成 Vec,并通过 Counter 替代 Guage。
  2. block_txns_count metrics 删除,因为从 block_txns_count 的 Guage 无法得出一个有效的监控信息。

@jolestar jolestar requested review from nanne007 and sanlee42 October 19, 2021 08:38
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2967 (16fedce) into master (7ef1c62) will increase coverage by 0.44%.
The diff coverage is 27.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2967      +/-   ##
==========================================
+ Coverage   33.03%   33.46%   +0.44%     
==========================================
  Files         516      516              
  Lines       45269    45292      +23     
  Branches    20623    20635      +12     
==========================================
+ Hits        14948    15154     +206     
+ Misses      15962    15954       -8     
+ Partials    14359    14184     -175     
Flag Coverage Δ
unittests 33.46% <27.42%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/peer-watcher/src/lib.rs 100.00% <ø> (ø)
network/src/service.rs 30.84% <0.00%> (+0.16%) ⬆️
network/src/worker.rs 33.88% <0.00%> (ø)
block-relayer/src/block_relayer.rs 25.14% <27.28%> (+1.44%) ⬆️
block-relayer/src/metrics.rs 33.34% <29.63%> (-5.12%) ⬇️
config/src/helper.rs 46.00% <0.00%> (-4.00%) ⬇️
network-p2p/src/request_responses.rs 31.36% <0.00%> (-2.43%) ⬇️
executor/src/account.rs 41.09% <0.00%> (-1.51%) ⬇️
vm/types/src/token/token_value.rs 58.34% <0.00%> (-1.38%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef1c62...16fedce. Read the comment docs.

@jolestar jolestar merged commit ed8bf2d into master Oct 20, 2021
@jolestar jolestar deleted the rework_on_metrics_network branch October 20, 2021 01:22
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
2 participants