Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework on metrics storage #2973

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Rework on metrics storage #2973

merged 3 commits into from
Oct 21, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Oct 20, 2021

重构了 miner 和 rpc 相关的 metrics。

storage 的 metric 在下一个 pr。

@jolestar jolestar marked this pull request as draft October 20, 2021 08:45
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #2973 (ea86ddc) into master (ed8bf2d) will decrease coverage by 0.03%.
The diff coverage is 40.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   33.20%   33.17%   -0.02%     
==========================================
  Files         516      517       +1     
  Lines       45294    45437     +143     
  Branches    20639    20695      +56     
==========================================
+ Hits        15036    15070      +34     
- Misses      15932    16013      +81     
- Partials    14326    14354      +28     
Flag Coverage Δ
unittests 33.17% <40.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/metrics/src/lib.rs 14.52% <0.00%> (ø)
...reate_block_template/test_create_block_template.rs 20.90% <0.00%> (+2.52%) ⬆️
rpc/server/src/module/node_rpc.rs 18.92% <0.00%> (-1.08%) ⬇️
miner/src/lib.rs 34.65% <20.00%> (-0.03%) ⬇️
rpc/middleware/src/tests.rs 20.84% <25.00%> (-1.89%) ⬇️
rpc/middleware/src/lib.rs 44.45% <26.32%> (-1.93%) ⬇️
rpc/server/src/api_registry.rs 38.71% <33.34%> (-11.29%) ⬇️
rpc/server/src/service.rs 38.07% <33.34%> (+0.16%) ⬆️
miner/src/metrics.rs 55.56% <45.46%> (+13.46%) ⬆️
miner/src/task.rs 40.91% <60.00%> (+5.91%) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8bf2d...ea86ddc. Read the comment docs.

@jolestar jolestar marked this pull request as ready for review October 20, 2021 10:08
@nanne007 nanne007 merged commit 344396f into master Oct 21, 2021
@nanne007 nanne007 deleted the rework_on_metrics_storage branch October 21, 2021 04:20
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
3 participants