Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Do not create the registry when users disable metrics in the option #2979

Merged
merged 4 commits into from
Oct 22, 2021

Conversation

jolestar
Copy link
Member

  1. Do not create the registry when users disable metrics in the option.
  2. Unify metrics name, use xxx_total for Counter metrics.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2979 (d19044a) into master (e26f2ce) will increase coverage by 0.24%.
The diff coverage is 29.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
+ Coverage   33.23%   33.46%   +0.24%     
==========================================
  Files         517      515       -2     
  Lines       45435    45662     +227     
  Branches    20694    20812     +118     
==========================================
+ Hits        15094    15278     +184     
+ Misses      16140    16109      -31     
- Partials    14201    14275      +74     
Flag Coverage Δ
unittests 33.46% <29.36%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/src/account_storage.rs 50.50% <0.00%> (-1.76%) ⬇️
block-relayer/src/block_relayer.rs 25.67% <0.00%> (+0.54%) ⬆️
chain/api/src/errors.rs 25.00% <0.00%> (-6.81%) ⬇️
cmd/generator/src/lib.rs 100.00% <ø> (ø)
commons/metrics/src/metric_server.rs 0.00% <0.00%> (ø)
config/src/metrics_config.rs 53.93% <0.00%> (-2.11%) ⬇️
config/src/rpc_config.rs 46.62% <0.00%> (-1.19%) ⬇️
...ntrib-contracts/src/eth_state_verifier_test/mod.rs 30.34% <0.00%> (-0.69%) ⬇️
contrib-contracts/src/genesis_nft_test.rs 35.30% <0.00%> (+1.97%) ⬆️
contrib-contracts/src/merkle_distributor_test.rs 22.56% <0.00%> (+1.19%) ⬆️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426392b...d19044a. Read the comment docs.

@jolestar jolestar merged commit f559cff into master Oct 22, 2021
@jolestar jolestar deleted the rework_on_metrics_fix branch October 22, 2021 05:06
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
2 participants