Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Add peers state metrics #2980

Merged
merged 1 commit into from
Oct 22, 2021
Merged

network: Add peers state metrics #2980

merged 1 commit into from
Oct 22, 2021

Conversation

sanlee42
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2980 (73fc19a) into master (f559cff) will decrease coverage by 0.02%.
The diff coverage is 56.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
- Coverage   33.19%   33.18%   -0.01%     
==========================================
  Files         515      515              
  Lines       45662    45688      +26     
  Branches    20812    20825      +13     
==========================================
  Hits        15155    15155              
- Misses      16055    16154      +99     
+ Partials    14452    14379      -73     
Flag Coverage Δ
unittests 33.18% <56.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network-p2p/src/metrics.rs 4.38% <0.00%> (-0.16%) ⬇️
network-p2p/src/service.rs 30.29% <45.46%> (-0.80%) ⬇️
network-p2p/peerset/src/lib.rs 42.56% <100.00%> (+0.59%) ⬆️
network-p2p/src/protocol.rs 41.56% <100.00%> (+1.29%) ⬆️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 21.38% <100.00%> (+0.22%) ⬆️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
executor/src/block_executor.rs 26.67% <0.00%> (-11.11%) ⬇️
storage/src/transaction_info/mod.rs 39.40% <0.00%> (-9.09%) ⬇️
storage/src/block/mod.rs 51.10% <0.00%> (-5.83%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f559cff...73fc19a. Read the comment docs.

@sanlee42 sanlee42 merged commit c4f2023 into master Oct 22, 2021
@sanlee42 sanlee42 deleted the network branch October 22, 2021 06:32
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
2 participants