Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] fix metric name and use type as label. #2984

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

jolestar
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2984 (43dc06c) into master (094a713) will increase coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
+ Coverage   33.29%   33.72%   +0.44%     
==========================================
  Files         515      515              
  Lines       45688    45688              
  Branches    20830    20830              
==========================================
+ Hits        15206    15405     +199     
+ Misses      16047    16043       -4     
+ Partials    14435    14240     -195     
Flag Coverage Δ
unittests 33.72% <0.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
block-relayer/src/metrics.rs 41.38% <ø> (+6.90%) ⬆️
txpool/src/lib.rs 46.22% <ø> (ø)
txpool/src/metrics.rs 36.00% <ø> (ø)
txpool/src/test.rs 15.67% <0.00%> (ø)
txpool/src/tx_pool_service_impl.rs 47.09% <ø> (ø)
commons/crypto/src/multi_ed25519/mod.rs 71.43% <0.00%> (-14.28%) ⬇️
vm/functional-tests/src/genesis_accounts.rs 37.50% <0.00%> (-12.50%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
network/src/worker.rs 45.17% <0.00%> (-4.83%) ⬇️
commons/crypto/src/multi_ed25519/multi_shard.rs 44.45% <0.00%> (-4.23%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094a713...43dc06c. Read the comment docs.

@jolestar jolestar merged commit 0bac892 into master Oct 26, 2021
@jolestar jolestar deleted the metrics_names branch October 26, 2021 06:30
@jolestar jolestar linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework on metrics
2 participants