Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Framework to halley #3604

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Update Framework to halley #3604

merged 2 commits into from
Aug 3, 2022

Conversation

WGB5445
Copy link
Contributor

@WGB5445 WGB5445 commented Aug 3, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@WGB5445 WGB5445 requested a review from jolestar as a code owner August 3, 2022 14:39
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #3604 (7aedad3) into master (c2aeb1f) will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
- Coverage   29.42%   29.15%   -0.26%     
==========================================
  Files         589      589              
  Lines       49860    49860              
  Branches    23465    23471       +6     
==========================================
- Hits        14665    14531     -134     
- Misses      21234    21261      +27     
- Partials    13961    14068     +107     
Flag Coverage Δ
unittests 29.15% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/natives/src/account.rs 12.50% <0.00%> (-12.50%) ⬇️
chain/src/verifier/mod.rs 30.99% <0.00%> (-7.04%) ⬇️
network-rpc/core/src/lib.rs 20.00% <0.00%> (-6.00%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 41.00% <0.00%> (-6.00%) ⬇️
vm/types/src/on_chain_config/mod.rs 47.95% <0.00%> (-5.47%) ⬇️
chain/open-block/src/lib.rs 37.09% <0.00%> (-4.63%) ⬇️
state/state-tree/src/mock/mod.rs 39.14% <0.00%> (-4.34%) ⬇️
chain/src/chain.rs 35.75% <0.00%> (-4.18%) ⬇️
txpool/src/pool/listener/tests.rs 10.91% <0.00%> (-3.63%) ⬇️
...k-p2p/src/protocol/generic_proto/upgrade/collec.rs 82.15% <0.00%> (-3.57%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2aeb1f...7aedad3. Read the comment docs.

@jolestar jolestar merged commit 2138b1e into master Aug 3, 2022
@jolestar jolestar deleted the update-framework branch August 3, 2022 16:22
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Benchmark for afe6853

Click to view benchmark
Test Base PR %
accumulator_append 611.2±32.18µs 606.6±30.08µs -0.75%
block_apply/block_apply_10 630.9±1.11ms 630.5±1.46ms -0.06%
block_apply/block_apply_1000 64.3±0.05s 64.6±0.03s +0.47%
get_with_proof/db_store 36.6±0.28µs 36.6±0.33µs 0.00%
get_with_proof/mem_store 31.5±0.28µs 31.4±0.37µs -0.32%
put_and_commit/db_store/1 96.3±5.25µs 95.3±4.99µs -1.04%
put_and_commit/db_store/10 856.2±38.43µs 859.1±60.40µs +0.34%
put_and_commit/db_store/100 7.3±0.30ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 437.7±22.12µs 436.2±22.00µs -0.34%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.2±5.71µs 62.1±6.21µs +1.47%
put_and_commit/mem_store/10 577.1±49.58µs 581.0±51.76µs +0.68%
put_and_commit/mem_store/100 5.6±0.83ms 5.6±0.82ms 0.00%
put_and_commit/mem_store/5 291.8±25.74µs 292.4±25.97µs +0.21%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 5.4±0.11ms 5.4±0.30ms 0.00%
query_block/query_block_in(10)_times(1000) 54.0±1.70ms 53.7±1.14ms -0.56%
query_block/query_block_in(10)_times(10000) 541.3±15.52ms 548.2±15.85ms +1.27%
query_block/query_block_in(1000)_times(100) 976.8±16.28µs 1010.1±11.97µs +3.41%
query_block/query_block_in(1000)_times(1000) 9.8±0.10ms 10.2±0.14ms +4.08%
query_block/query_block_in(1000)_times(10000) 97.3±0.64ms 100.3±1.21ms +3.08%
storage_transaction 1062.4±269.81µs 1060.0±264.71µs -0.23%
vm/transaction_execution/1 705.6±1.57ms 708.0±3.47ms +0.34%
vm/transaction_execution/10 175.7±0.39ms 176.4±0.33ms +0.40%
vm/transaction_execution/20 151.8±1.10ms 152.2±0.41ms +0.26%
vm/transaction_execution/5 232.2±0.50ms 232.7±0.47ms +0.22%
vm/transaction_execution/50 166.7±1.83ms 166.8±0.51ms +0.06%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants