-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rpc] improve state.list_resource
filters
#3615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3615 +/- ##
==========================================
- Coverage 29.29% 28.61% -0.67%
==========================================
Files 589 591 +2
Lines 49864 50454 +590
Branches 23450 23777 +327
==========================================
- Hits 14601 14431 -170
- Misses 21264 21825 +561
- Partials 13999 14198 +199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@jolestar @jiangying000 麻烦看下这个处理方式,另外这个任务和 #3614 #3613 有多少联系? 可否先合并这个任务,再处理另外两个issues? |
分开搞比较合适 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改完了需要加个集成测试
这个 PR 怎么样了?准备这两天发布新版本,这个可以争取合并进来吗? |
还在处理中,我争取能合并进去吧。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compared_suport_generics 需要一些 unit test
state.list_resource
filters
@YusongWang 我在 #3638 这里重构了一下,帮忙 review 下 |
Pull request type
What is the current behavior?
Issue Number: #3612