Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] improve state.list_resource filters #3615

Merged
merged 9 commits into from
Aug 11, 2022
Merged

[rpc] improve state.list_resource filters #3615

merged 9 commits into from
Aug 11, 2022

Conversation

YouNeedWork
Copy link
Contributor

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3612

@YouNeedWork YouNeedWork requested a review from sanlee42 as a code owner August 4, 2022 09:01
@YouNeedWork YouNeedWork marked this pull request as draft August 4, 2022 09:37
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3615 (8b14ccd) into master (8aa6bf2) will decrease coverage by 0.68%.
The diff coverage is 0.00%.

❗ Current head 8b14ccd differs from pull request most recent head 43badb6. Consider uploading reports for the commit 43badb6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3615      +/-   ##
==========================================
- Coverage   29.29%   28.61%   -0.67%     
==========================================
  Files         589      591       +2     
  Lines       49864    50454     +590     
  Branches    23450    23777     +327     
==========================================
- Hits        14601    14431     -170     
- Misses      21264    21825     +561     
- Partials    13999    14198     +199     
Flag Coverage Δ
unittests 28.61% <0.00%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/state/mod.rs 31.92% <ø> (-0.69%) ⬇️
rpc/client/src/lib.rs 11.14% <ø> (-0.08%) ⬇️
rpc/server/src/module/state_rpc.rs 4.21% <0.00%> (-0.70%) ⬇️
commons/accumulator/src/tree.rs 53.10% <0.00%> (-13.71%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-11.92%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
executor/src/block_executor.rs 25.59% <0.00%> (-9.30%) ⬇️
vm/types/src/on_chain_config/mod.rs 41.10% <0.00%> (-8.21%) ⬇️
types/src/account_state.rs 56.67% <0.00%> (-6.66%) ⬇️
state/state-store-api/src/lib.rs 31.25% <0.00%> (-6.25%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa6bf2...43badb6. Read the comment docs.

@YouNeedWork YouNeedWork marked this pull request as ready for review August 5, 2022 04:47
@YouNeedWork
Copy link
Contributor Author

@jolestar @jiangying000 麻烦看下这个处理方式,另外这个任务和 #3614 #3613 有多少联系? 可否先合并这个任务,再处理另外两个issues?

rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
@jolestar
Copy link
Member

jolestar commented Aug 5, 2022

@jolestar @jiangying000 麻烦看下这个处理方式,另外这个任务和 #3614 #3613 有多少联系? 可否先合并这个任务,再处理另外两个issues?

分开搞比较合适

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改完了需要加个集成测试

rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
@jolestar
Copy link
Member

jolestar commented Aug 9, 2022

这个 PR 怎么样了?准备这两天发布新版本,这个可以争取合并进来吗?

@YouNeedWork
Copy link
Contributor Author

这个 PR 怎么样了?准备这两天发布新版本,这个可以争取合并进来吗?

还在处理中,我争取能合并进去吧。

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared_suport_generics 需要一些 unit test

rpc/server/src/module/state_rpc.rs Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
rpc/server/src/module/state_rpc.rs Outdated Show resolved Hide resolved
@jolestar jolestar merged commit e2513cb into starcoinorg:master Aug 11, 2022
@jolestar jolestar changed the title [rpc] suport short address [rpc] improve state.list_resource filters Aug 11, 2022
@YouNeedWork YouNeedWork deleted the fixaddress branch August 11, 2022 04:09
@jolestar
Copy link
Member

@YusongWang 我在 #3638 这里重构了一下,帮忙 review 下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] state.list_resource resource_types filter do not work use short address.
3 participants