Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genesis] Fix the genesis generate dir. #3616

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Aug 4, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Ensure the genesis dir is genesis/generated

Other information

@jolestar jolestar requested review from nkysg and WGB5445 August 4, 2022 12:55
@jolestar
Copy link
Member Author

jolestar commented Aug 4, 2022

@WGB5445 修复了 genesis 路径问题

@WGB5445
Copy link
Contributor

WGB5445 commented Aug 4, 2022

@WGB5445 修复了 genesis 路径问题

我明白了,之前不能直接生成是因为:
默认的生成路径在项目根目录下,但是 starcoin node 依赖 genesis/generated 所以配置未更新

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Benchmark for eb5e9a2

Click to view benchmark
Test Base PR %
accumulator_append 607.9±31.56µs 606.7±28.27µs -0.20%
block_apply/block_apply_10 634.0±1.16ms 631.9±0.74ms -0.33%
block_apply/block_apply_1000 65.2±0.10s 64.6±0.09s -0.92%
get_with_proof/db_store 36.3±0.22µs 36.4±0.22µs +0.28%
get_with_proof/mem_store 31.7±0.22µs 31.7±0.40µs 0.00%
put_and_commit/db_store/1 95.7±5.12µs 95.7±4.95µs 0.00%
put_and_commit/db_store/10 862.0±41.15µs 858.1±39.32µs -0.45%
put_and_commit/db_store/100 7.4±0.29ms 7.3±0.28ms -1.35%
put_and_commit/db_store/5 447.3±23.61µs 437.5±21.54µs -2.19%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.7±5.65µs 61.6±5.70µs -0.16%
put_and_commit/mem_store/10 577.7±47.93µs 579.5±49.65µs +0.31%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 292.2±25.27µs 290.8±24.84µs -0.48%
put_and_commit/mem_store/50 2.9±0.19ms 2.8±0.18ms -3.45%
query_block/query_block_in(10)_times(100) 5.5±0.12ms 5.6±0.18ms +1.82%
query_block/query_block_in(10)_times(1000) 54.4±1.73ms 53.0±1.66ms -2.57%
query_block/query_block_in(10)_times(10000) 548.8±10.29ms 541.4±14.32ms -1.35%
query_block/query_block_in(1000)_times(100) 971.3±10.11µs 991.0±10.57µs +2.03%
query_block/query_block_in(1000)_times(1000) 9.7±0.07ms 9.9±0.08ms +2.06%
query_block/query_block_in(1000)_times(10000) 96.7±1.04ms 99.3±1.22ms +2.69%
storage_transaction 1116.9±355.92µs 1112.3±443.25µs -0.41%
vm/transaction_execution/1 718.1±1.71ms 711.6±2.72ms -0.91%
vm/transaction_execution/10 179.4±1.97ms 177.2±1.31ms -1.23%
vm/transaction_execution/20 153.8±0.37ms 152.5±0.30ms -0.85%
vm/transaction_execution/5 236.9±0.78ms 233.7±0.68ms -1.35%
vm/transaction_execution/50 168.5±0.97ms 167.6±1.42ms -0.53%

@nkysg nkysg merged commit e92d203 into master Aug 4, 2022
@nkysg nkysg deleted the fix_genesis_generate branch August 4, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants