Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency merkletree remove rust-crypto #3632

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Aug 9, 2022

remove Cargo.lock rust-crypto for security

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • [] Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

remove https://github.com/starcoinorg/starcoin/security/dependabot/20

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #3632 (73ced24) into master (38e141e) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3632      +/-   ##
==========================================
- Coverage   28.76%   28.54%   -0.22%     
==========================================
  Files         591      591              
  Lines       50428    50428              
  Branches    23766    23766              
==========================================
- Hits        14503    14392     -111     
- Misses      21742    22010     +268     
+ Partials    14183    14026     -157     
Flag Coverage Δ
unittests 28.54% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 25.72% <0.00%> (-8.57%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-7.14%) ⬇️
vm/natives/src/token.rs 17.78% <0.00%> (-6.66%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 21.71% <0.00%> (-6.20%) ⬇️
vm/types/src/transaction_metadata.rs 61.20% <0.00%> (-5.97%) ⬇️
types/src/system_events.rs 65.22% <0.00%> (-4.34%) ⬇️
vm/natives/src/vector.rs 12.50% <0.00%> (-4.16%) ⬇️
vm/vm-runtime/src/metrics.rs 25.00% <0.00%> (-4.16%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14aaf84...73ced24. Read the comment docs.

@github-actions
Copy link

Benchmark for 7e7e9ec

Click to view benchmark
Test Base PR %
accumulator_append 603.7±28.05µs 600.4±29.74µs -0.55%
block_apply/block_apply_10 630.2±1.76ms 632.4±2.49ms +0.35%
block_apply/block_apply_1000 64.4±0.07s 64.2±0.12s -0.31%
get_with_proof/db_store 36.3±0.36µs 36.5±0.83µs +0.55%
get_with_proof/mem_store 31.2±0.24µs 31.7±0.20µs +1.60%
put_and_commit/db_store/1 95.2±5.03µs 95.4±5.04µs +0.21%
put_and_commit/db_store/10 848.1±40.82µs 854.4±38.94µs +0.74%
put_and_commit/db_store/100 7.3±0.31ms 7.3±0.29ms 0.00%
put_and_commit/db_store/5 439.3±21.73µs 439.0±22.60µs -0.07%
put_and_commit/db_store/50 3.8±0.15ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.7±5.70µs 61.3±5.69µs -0.65%
put_and_commit/mem_store/10 574.8±47.05µs 574.7±47.93µs -0.02%
put_and_commit/mem_store/100 5.7±0.86ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 291.9±25.81µs 290.2±24.60µs -0.58%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 5.4±0.18ms 5.4±0.24ms 0.00%
query_block/query_block_in(10)_times(1000) 54.3±1.36ms 54.2±2.15ms -0.18%
query_block/query_block_in(10)_times(10000) 542.1±12.40ms 541.9±18.29ms -0.04%
query_block/query_block_in(1000)_times(100) 1010.9±14.78µs 977.9±8.71µs -3.26%
query_block/query_block_in(1000)_times(1000) 10.1±0.07ms 9.7±0.11ms -3.96%
query_block/query_block_in(1000)_times(10000) 100.7±0.72ms 98.2±1.20ms -2.48%
storage_transaction 1074.4±278.02µs 1070.0±274.83µs -0.41%
vm/transaction_execution/1 708.7±9.57ms 708.1±1.87ms -0.08%
vm/transaction_execution/10 176.8±2.33ms 178.0±4.50ms +0.68%
vm/transaction_execution/20 152.6±1.61ms 151.8±0.28ms -0.52%
vm/transaction_execution/5 232.6±0.82ms 232.8±0.67ms +0.09%
vm/transaction_execution/50 166.6±0.67ms 166.5±0.69ms -0.06%

@nkysg nkysg merged commit ce17ac4 into master Aug 10, 2022
@nkysg nkysg deleted the update_merkle_generator branch August 10, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants