Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep][security] bump filecoin-project/merkletree, remove memmap #3671

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

jiangying000
Copy link
Collaborator

use maintained memmap2
address #2403

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): dependency upgrade

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jiangying000 jiangying000 linked an issue Aug 18, 2022 that may be closed by this pull request
@jolestar jolestar requested a review from nkysg August 18, 2022 08:31
@jiangying000 jiangying000 marked this pull request as draft August 18, 2022 08:31
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #3671 (4a88658) into master (e4cd29e) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3671      +/-   ##
==========================================
+ Coverage   28.59%   28.67%   +0.09%     
==========================================
  Files         591      591              
  Lines       50687    50687              
  Branches    23877    23877              
==========================================
+ Hits        14490    14531      +41     
+ Misses      21978    21907      -71     
- Partials    14219    14249      +30     
Flag Coverage Δ
unittests 28.67% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-5.97%) ⬇️
config/src/helper.rs 37.26% <0.00%> (-3.92%) ⬇️
network-rpc/api/src/lib.rs 20.66% <0.00%> (-3.26%) ⬇️
commons/service-registry/src/service_actor.rs 37.64% <0.00%> (-3.22%) ⬇️
commons/accumulator/src/tree_store/mock.rs 28.58% <0.00%> (-2.85%) ⬇️
vm/types/src/token/token_value.rs 55.56% <0.00%> (-2.77%) ⬇️
commons/service-registry/src/service_ref.rs 65.76% <0.00%> (-2.73%) ⬇️
network-rpc/src/rpc.rs 19.57% <0.00%> (-2.17%) ⬇️
storage/src/db_storage/mod.rs 40.43% <0.00%> (-2.12%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cd29e...4a88658. Read the comment docs.

@jiangying000 jiangying000 marked this pull request as ready for review August 18, 2022 16:58
@jolestar jolestar merged commit 424a830 into starcoinorg:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0077: memmap is unmaintained
2 participants