-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-coverage] use cargo llvm-cov
to generate coverage info
#3693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3693 +/- ##
===========================================
+ Coverage 28.45% 55.24% +26.79%
===========================================
Files 588 597 +9
Lines 50412 64304 +13892
Branches 23644 0 -23644
===========================================
+ Hits 14342 35516 +21174
- Misses 22172 28788 +6616
+ Partials 13898 0 -13898
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cargo llvm-cov
to generate coverage info
cargo llvm-cov
to generate coverage infocargo llvm-cov
to generate coverage info
failed to upload report: https://github.com/starcoinorg/starcoin/runs/8075909445?check_suite_focus=true#step:8:48
relate to: codecov/codecov-action#557 retry like: redhat-plumbers-in-action/differential-shellcheck#79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3666
What is the new behavior?
core dump
mention in Maybe the coverage report has a bug, the coverage is suddenly reduced. Diem project does some report hack. https://app.codecov.io/gh/starcoinorg/starcoin #3666 is hard to deal with and it's using debug info to collect cov data, so maybe use another approach to collect coverage infocargo llvm-cov
to gen coverage infoOther information