Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-coverage] use cargo llvm-cov to generate coverage info #3693

Merged
merged 32 commits into from
Aug 30, 2022

Conversation

jiangying000
Copy link
Collaborator

@jiangying000 jiangying000 commented Aug 29, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3666

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3693 (f7fb529) into master (8bd77a6) will increase coverage by 26.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3693       +/-   ##
===========================================
+ Coverage   28.45%   55.24%   +26.79%     
===========================================
  Files         588      597        +9     
  Lines       50412    64304    +13892     
  Branches    23644        0    -23644     
===========================================
+ Hits        14342    35516    +21174     
- Misses      22172    28788     +6616     
+ Partials    13898        0    -13898     
Flag Coverage Δ
unittests 55.24% <ø> (+26.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/transaction-builder-generator/src/lib.rs 1.52% <0.00%> (-98.48%) ⬇️
cmd/generator/src/lib.rs 3.85% <0.00%> (-96.15%) ⬇️
cmd/peer-watcher/src/lib.rs 6.25% <0.00%> (-93.75%) ⬇️
vm/types/src/write_set.rs 45.46% <0.00%> (-18.64%) ⬇️
vm/types/src/transaction/helpers.rs 9.38% <0.00%> (-17.89%) ⬇️
cmd/indexer/src/lib.rs 50.68% <0.00%> (-15.99%) ⬇️
network-p2p/src/protocol/event.rs 16.67% <0.00%> (-11.90%) ⬇️
commons/utils/src/mpsc.rs 42.86% <0.00%> (-8.92%) ⬇️
vm/move-package-manager/src/lib.rs 0.54% <0.00%> (-7.16%) ⬇️
commons/time-service/src/lib.rs 65.79% <0.00%> (-7.12%) ⬇️
... and 561 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd77a6...f7fb529. Read the comment docs.

@jiangying000 jiangying000 marked this pull request as ready for review August 29, 2022 15:34
@jiangying000 jiangying000 changed the title [cov] llvm-cov [cov] use cargo llvm-cov to generate coverage info Aug 29, 2022
@jiangying000 jiangying000 changed the title [cov] use cargo llvm-cov to generate coverage info [code-coverage] use cargo llvm-cov to generate coverage info Aug 29, 2022
@jiangying000
Copy link
Collaborator Author

jiangying000 commented Aug 29, 2022

failed to upload report: https://github.com/starcoinorg/starcoin/runs/8075909445?check_suite_focus=true#step:8:48

    {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

relate to: codecov/codecov-action#557

retry like: redhat-plumbers-in-action/differential-shellcheck#79

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants