Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock display for account show #3694

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

Lynskylate
Copy link
Contributor

Add lock status display for account show command. Try to fix #3690

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3694 (3f7f611) into master (8bd77a6) will decrease coverage by 0.06%.
The diff coverage is 10.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   28.45%   28.40%   -0.05%     
==========================================
  Files         588      588              
  Lines       50412    50430      +18     
  Branches    23644    23660      +16     
==========================================
- Hits        14342    14321      -21     
- Misses      22172    22222      +50     
+ Partials    13898    13887      -11     
Flag Coverage Δ
unittests 28.40% <10.53%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/types.rs 43.25% <0.00%> (-1.20%) ⬇️
account/src/account.rs 49.50% <ø> (ø)
account/src/account_manager.rs 34.29% <0.00%> (+2.71%) ⬆️
account/src/account_test.rs 8.91% <12.50%> (+0.45%) ⬆️
types/src/lib.rs 9.10% <0.00%> (-36.36%) ⬇️
types/src/account_state.rs 56.67% <0.00%> (-6.66%) ⬇️
vm/types/src/transaction/package.rs 32.26% <0.00%> (-4.83%) ⬇️
types/src/startup_info.rs 58.52% <0.00%> (-4.44%) ⬇️
network-p2p/src/peer_info.rs 45.08% <0.00%> (-4.14%) ⬇️
types/src/compact_block.rs 32.26% <0.00%> (-3.22%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd77a6...3f7f611. Read the comment docs.

@jolestar
Copy link
Member

Please run scripts/check_commit.sh for generate RPC schema.

@Lynskylate Lynskylate requested a review from sanlee42 as a code owner August 29, 2022 07:14
@Lynskylate
Copy link
Contributor Author

@jolestar AccountInfo::from 我看除了db-exporter这个bin文件, 实际上一直没有被使用, 而且这里的Account是starcoin_types里面的account, 导致测试很难覆盖到,目前的测试结构上看,这个测试放在哪都不是很合适

@jolestar
Copy link
Member

@jolestar AccountInfo::from 我看除了db-exporter这个bin文件, 实际上一直没有被使用, 而且这里的Account是starcoin_types里面的account, 导致测试很难覆盖到,目前的测试结构上看,这个测试放在哪都不是很合适

感觉这个未来可以想办法消除掉

@jolestar jolestar merged commit a477fc5 into starcoinorg:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] 希望在 account show 命令请求的结果中增加当前账户是否锁定的信息。
2 participants