Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db-exporter] Add verify-modules command for fast verify modules #3740

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

jolestar
Copy link
Member

Add verify-modules command to db_exporter for fast verify all modules in transactions.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jolestar jolestar requested a review from nkysg September 18, 2022 09:45
@jolestar jolestar requested a review from templexxx as a code owner September 18, 2022 09:45
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #3740 (486c31c) into master (b33372a) will decrease coverage by 0.15%.
The diff coverage is 1.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
- Coverage   55.75%   55.60%   -0.14%     
==========================================
  Files         597      598       +1     
  Lines       64424    64521      +97     
==========================================
- Hits        35914    35872      -42     
- Misses      28510    28649     +139     
Flag Coverage Δ
unittests 55.60% <1.04%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/db-exporter/src/lib.rs 1.04% <1.04%> (ø)
network-rpc/core/src/lib.rs 31.15% <0.00%> (-4.91%) ⬇️
network/api/src/peer_provider.rs 51.03% <0.00%> (-2.91%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 41.16% <0.00%> (-2.59%) ⬇️
sync/src/tasks/mock.rs 86.64% <0.00%> (-2.42%) ⬇️
network-p2p/src/protocol/generic_proto/handler.rs 79.51% <0.00%> (-1.10%) ⬇️
sync/src/tasks/mod.rs 78.23% <0.00%> (-0.88%) ⬇️
commons/accumulator/src/inmemory/mod.rs 87.96% <0.00%> (-0.52%) ⬇️
commons/accumulator/src/node_index.rs 92.90% <0.00%> (-0.50%) ⬇️
network-p2p/peerset/src/peersstate.rs 85.98% <0.00%> (-0.40%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33372a...486c31c. Read the comment docs.

@github-actions
Copy link

Benchmark for c12e52f

Click to view benchmark
Test Base PR %
accumulator_append 611.6±29.49µs 601.6±27.50µs -1.64%
block_apply/block_apply_10 634.4±6.14ms 633.5±1.51ms -0.14%
block_apply/block_apply_1000 64.7±0.05s 64.6±0.10s -0.15%
get_with_proof/db_store 36.2±0.25µs 37.1±0.46µs +2.49%
get_with_proof/mem_store 31.3±0.20µs 31.7±0.31µs +1.28%
put_and_commit/db_store/1 97.1±5.21µs 96.2±4.88µs -0.93%
put_and_commit/db_store/10 859.9±40.84µs 855.1±40.98µs -0.56%
put_and_commit/db_store/100 7.3±0.29ms 7.3±0.28ms 0.00%
put_and_commit/db_store/5 439.8±19.54µs 439.5±22.46µs -0.07%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.9±5.75µs 61.7±5.70µs -0.32%
put_and_commit/mem_store/10 575.2±47.31µs 579.4±49.77µs +0.73%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 292.3±25.72µs 291.2±24.61µs -0.38%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 5.3±0.26ms 5.5±0.08ms +3.77%
query_block/query_block_in(10)_times(1000) 53.8±1.35ms 54.5±0.99ms +1.30%
query_block/query_block_in(10)_times(10000) 545.0±13.23ms 541.9±17.40ms -0.57%
query_block/query_block_in(1000)_times(100) 959.5±9.18µs 984.2±9.11µs +2.57%
query_block/query_block_in(1000)_times(1000) 9.6±0.08ms 9.8±0.09ms +2.08%
query_block/query_block_in(1000)_times(10000) 96.3±1.09ms 98.5±1.33ms +2.28%
storage_transaction 1103.0±291.07µs 1108.5±287.15µs +0.50%
vm/transaction_execution/1 710.2±1.05ms 711.2±1.15ms +0.14%
vm/transaction_execution/10 177.2±0.88ms 177.0±0.53ms -0.11%
vm/transaction_execution/20 152.6±0.41ms 152.8±0.74ms +0.13%
vm/transaction_execution/5 234.3±1.80ms 234.1±1.33ms -0.09%
vm/transaction_execution/50 167.7±1.53ms 167.5±1.58ms -0.12%

@jolestar jolestar merged commit 0a25279 into master Sep 19, 2022
@jolestar jolestar deleted the db_export_verify_modules branch September 19, 2022 00:30
@jolestar
Copy link
Member Author

@yourmoonlight 感觉这个可以作为一个测试任务,每次变更都跑一下,避免造成不兼容。

@yourmoonlight
Copy link
Collaborator

@yourmoonlight 感觉这个可以作为一个测试任务,每次变更都跑一下,避免造成不兼容。

好的,我看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants