Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update move and add some tests #3796

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Update move and add some tests #3796

merged 4 commits into from
Nov 14, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Nov 13, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #3796 (cac5cd1) into master (61d76f0) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3796      +/-   ##
==========================================
- Coverage   53.65%   53.60%   -0.05%     
==========================================
  Files         594      594              
  Lines       64148    64163      +15     
==========================================
- Hits        34414    34386      -28     
- Misses      29734    29777      +43     
Flag Coverage Δ
unittests 53.60% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test-helper/src/executor.rs 42.98% <0.00%> (-1.71%) ⬇️
vm/stdlib/src/lib.rs 46.81% <0.00%> (-1.01%) ⬇️
vm/transaction-builder/src/lib.rs 32.53% <ø> (ø)
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 69.79% <0.00%> (-7.55%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 41.16% <0.00%> (-2.59%) ⬇️
sync/src/tasks/accumulator_sync_task.rs 96.16% <0.00%> (-1.28%) ⬇️
network-p2p/src/protocol/generic_proto/handler.rs 79.51% <0.00%> (-1.10%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 91.44% <0.00%> (-0.55%) ⬇️
network-p2p/peerset/src/peersstate.rs 85.98% <0.00%> (-0.40%) ⬇️
network-p2p/src/discovery.rs 72.21% <0.00%> (+0.13%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d76f0...cac5cd1. Read the comment docs.

@nanne007
Copy link
Member

fmt error

@jolestar jolestar merged commit b36b8fd into master Nov 14, 2022
@jolestar jolestar deleted the update_move_verifier branch November 14, 2022 03:19
@jolestar
Copy link
Member Author

verify all modules by scripts/verify_module.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants