[Feature] RPC blocks support positive sequence #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGB5445
requested review from
nanne007,
sanlee42 and
templexxx
as code owners
Benchmark for 1f0cd01Click to view benchmark
|
jolestar
approved these changes
Dec 28, 2022
nkysg
reviewed
Dec 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #3824 +/- ##
==========================================
+ Coverage 53.13% 53.20% +0.07%
==========================================
Files 595 595
Lines 64668 64700 +32
==========================================
+ Hits 34353 34415 +62
+ Misses 30315 30285 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for a6fb853Click to view benchmark
|
welbon
approved these changes
Dec 28, 2022
nkysg
reviewed
Dec 28, 2022
chain/api/src/chain.rs
Outdated
| @@ -36,7 +36,12 @@ pub trait ChainReader { | |||
| fn get_block_by_number(&self, number: BlockNumber) -> Result<Option<Block>>; | |||
| /// Get latest `count` blocks before `number`. if `number` is absent, use head block number. | |||
nkysg
reviewed
Dec 28, 2022
| let blocks = mock_chain | ||
| .head() | ||
| .get_blocks_by_number(Some(9), false, u64::max_value())?; | ||
| assert_eq!(blocks.len(), 2); |
There was a problem hiding this comment.
这里需要加个Some(9), true, 3 类似这种测试用例吗
nkysg
approved these changes
Dec 28, 2022
Benchmark for 8afdd8aClick to view benchmark
|
Benchmark for 2a5b85fClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3799