Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add struct republish backward incompatible test #3833

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jan 12, 2023

starcoinorg/move#49
add struct republish backward incompatible test

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #3833 (78e1edb) into master (f9ba8b6) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 78e1edb differs from pull request most recent head aeec931. Consider uploading reports for the commit aeec931 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3833      +/-   ##
==========================================
+ Coverage   53.19%   53.22%   +0.04%     
==========================================
  Files         595      595              
  Lines       64702    64702              
==========================================
+ Hits        34409    34429      +20     
+ Misses      30293    30273      -20     
Flag Coverage Δ
unittests 53.22% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
types/src/sync_status.rs 65.08% <0.00%> (-12.69%) ⬇️
storage/src/transaction_info/mod.rs 78.58% <0.00%> (-3.57%) ⬇️
commons/service-registry/src/service_actor.rs 71.91% <0.00%> (-2.47%) ⬇️
sync/src/tasks/accumulator_sync_task.rs 96.16% <0.00%> (-1.28%) ⬇️
sync/src/tasks/block_sync_task.rs 90.63% <0.00%> (-0.89%) ⬇️
commons/service-registry/src/service_ref.rs 62.76% <0.00%> (-0.68%) ⬇️
sync/src/sync.rs 61.84% <0.00%> (-0.22%) ⬇️
...able-jellyfish-merkle/src/jellyfish_merkle_test.rs 99.89% <0.00%> (+0.12%) ⬆️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 91.99% <0.00%> (+0.56%) ⬆️
sync/src/tasks/mod.rs 79.12% <0.00%> (+0.89%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ba8b6...aeec931. Read the comment docs.

@github-actions
Copy link

Benchmark for 6da889e

Click to view benchmark
Test Base PR %
accumulator_append 607.0±31.94µs 603.6±28.30µs -0.56%
block_apply/block_apply_10 799.8±5.39ms 793.0±4.22ms -0.85%
block_apply/block_apply_1000 81.2±0.06s 80.4±0.03s -0.99%
get_with_proof/db_store 36.2±0.18µs 36.5±0.33µs +0.83%
get_with_proof/mem_store 31.3±0.14µs 31.3±0.24µs 0.00%
put_and_commit/db_store/1 95.6±5.09µs 95.5±5.00µs -0.10%
put_and_commit/db_store/10 852.2±39.48µs 851.6±39.04µs -0.07%
put_and_commit/db_store/100 7.3±0.31ms 7.3±0.30ms 0.00%
put_and_commit/db_store/5 437.4±20.90µs 437.2±21.75µs -0.05%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.7±5.68µs 61.5±5.63µs -0.32%
put_and_commit/mem_store/10 575.6±46.83µs 575.7±46.77µs +0.02%
put_and_commit/mem_store/100 5.6±0.34ms 5.6±0.35ms 0.00%
put_and_commit/mem_store/5 290.9±24.61µs 290.0±24.42µs -0.31%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 7.0±0.25ms 7.1±0.48ms +1.43%
query_block/query_block_in(10)_times(1000) 69.4±2.35ms 68.4±4.09ms -1.44%
query_block/query_block_in(10)_times(10000) 698.4±22.07ms 699.7±21.39ms +0.19%
query_block/query_block_in(1000)_times(100) 984.9±14.88µs 1016.4±12.44µs +3.20%
query_block/query_block_in(1000)_times(1000) 9.9±0.10ms 9.9±0.08ms 0.00%
query_block/query_block_in(1000)_times(10000) 99.6±2.96ms 99.7±1.38ms +0.10%
storage_transaction 1005.4±313.61µs 967.6±257.40µs -3.76%
vm/transaction_execution/1 903.5±1.92ms 906.9±4.45ms +0.38%
vm/transaction_execution/10 229.1±1.22ms 229.3±1.52ms +0.09%
vm/transaction_execution/20 197.5±2.03ms 196.9±0.32ms -0.30%
vm/transaction_execution/5 301.1±0.82ms 301.7±1.67ms +0.20%
vm/transaction_execution/50 213.2±1.82ms 213.2±0.71ms 0.00%

@jolestar
Copy link
Member

This is a more straightforward test case


//# publish
module 0x42.N {
    struct T{f: bool}
    struct T2{
        t: Self.T,
    }
}

//# publish
module 0x42.N {
    native struct T;
    struct T2{
        t: Self.T,
    }
}

@nkysg
Copy link
Collaborator Author

nkysg commented Jan 17, 2023

这个按照@jolestar提供的例子,我再添加下

@github-actions
Copy link

Benchmark for 96bc94f

Click to view benchmark
Test Base PR %
accumulator_append 606.5±30.54µs 614.1±27.25µs +1.25%
block_apply/block_apply_10 792.9±2.00ms 798.5±2.96ms +0.71%
block_apply/block_apply_1000 80.4±0.19s 80.5±0.06s +0.12%
get_with_proof/db_store 36.6±0.48µs 36.1±0.17µs -1.37%
get_with_proof/mem_store 31.6±0.18µs 31.4±0.15µs -0.63%
put_and_commit/db_store/1 95.9±5.09µs 95.9±4.67µs 0.00%
put_and_commit/db_store/10 858.2±40.06µs 854.5±39.83µs -0.43%
put_and_commit/db_store/100 7.3±0.30ms 7.3±0.29ms 0.00%
put_and_commit/db_store/5 438.9±23.28µs 440.3±21.97µs +0.32%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.67µs 61.9±5.65µs +0.65%
put_and_commit/mem_store/10 576.2±47.19µs 581.9±50.92µs +0.99%
put_and_commit/mem_store/100 5.7±0.85ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 290.9±24.46µs 293.1±25.39µs +0.76%
put_and_commit/mem_store/50 2.8±0.18ms 2.9±0.18ms +3.57%
query_block/query_block_in(10)_times(100) 7.0±0.15ms 6.9±0.35ms -1.43%
query_block/query_block_in(10)_times(1000) 69.3±1.49ms 69.3±2.16ms 0.00%
query_block/query_block_in(10)_times(10000) 695.5±17.03ms 698.7±15.25ms +0.46%
query_block/query_block_in(1000)_times(100) 1023.0±8.61µs 1006.2±12.81µs -1.64%
query_block/query_block_in(1000)_times(1000) 10.1±0.10ms 10.0±0.12ms -0.99%
query_block/query_block_in(1000)_times(10000) 101.3±1.66ms 99.5±1.42ms -1.78%
storage_transaction 1195.5±803.16µs 989.4±300.85µs -17.24%
vm/transaction_execution/1 907.2±3.45ms 907.1±2.71ms -0.01%
vm/transaction_execution/10 229.4±0.61ms 230.0±2.13ms +0.26%
vm/transaction_execution/20 197.7±0.82ms 198.6±1.85ms +0.46%
vm/transaction_execution/5 301.9±0.67ms 302.9±0.95ms +0.33%
vm/transaction_execution/50 213.5±0.94ms 213.5±0.57ms 0.00%

@nkysg nkysg merged commit b5788d6 into master Jan 31, 2023
@nkysg nkysg deleted the test_struct_new_native branch January 31, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants