Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update starcoin-proxima.yaml and starcoin-barnard.yaml #3869

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Mar 7, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from yourmoonlight as a code owner March 7, 2023 14:38
@nkysg nkysg requested review from sanlee42 and welbon and removed request for yourmoonlight March 7, 2023 14:39
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3869 (0a83801) into master (88f707d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
+ Coverage   53.93%   53.94%   +0.02%     
==========================================
  Files         616      616              
  Lines       67787    67787              
==========================================
+ Hits        36554    36562       +8     
+ Misses      31233    31225       -8     
Flag Coverage Δ
unittests 53.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/service-registry/src/service_actor.rs 74.39% <0.00%> (-1.65%) ⬇️
network-p2p/src/peer_info.rs 66.45% <0.00%> (+0.67%) ⬆️
network-p2p/src/discovery.rs 65.73% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f707d...0a83801. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Benchmark for ef794db

Click to view benchmark
Test Base PR %
accumulator_append 601.2±31.08µs 600.8±27.01µs -0.07%
block_apply/block_apply_10 258.4±0.94ms 258.5±0.77ms +0.04%
block_apply/block_apply_1000 26.9±0.15s 26.7±0.02s -0.74%
get_with_proof/db_store 36.1±0.17µs 36.4±0.25µs +0.83%
get_with_proof/mem_store 31.3±0.15µs 31.4±0.19µs +0.32%
put_and_commit/db_store/1 97.6±4.83µs 96.7±5.00µs -0.92%
put_and_commit/db_store/10 860.4±39.49µs 873.6±42.13µs +1.53%
put_and_commit/db_store/100 7.4±0.30ms 7.4±0.29ms 0.00%
put_and_commit/db_store/5 449.3±22.58µs 420.3±22.72µs -6.45%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 62.6±5.54µs 61.6±5.68µs -1.60%
put_and_commit/mem_store/10 581.3±48.32µs 577.8±47.70µs -0.60%
put_and_commit/mem_store/100 5.7±0.84ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 293.9±24.75µs 291.7±24.55µs -0.75%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.7±0.12ms 3.9±0.07ms +5.41%
query_block/query_block_in(10)_times(1000) 39.0±1.63ms 38.5±1.29ms -1.28%
query_block/query_block_in(10)_times(10000) 381.5±5.17ms 387.8±8.58ms +1.65%
query_block/query_block_in(1000)_times(100) 956.4±5.54µs 970.9±9.48µs +1.52%
query_block/query_block_in(1000)_times(1000) 9.5±0.05ms 9.8±0.09ms +3.16%
query_block/query_block_in(1000)_times(10000) 95.5±0.47ms 97.1±0.64ms +1.68%
storage_transaction 1016.7±282.81µs 1026.6±295.51µs +0.97%
vm/transaction_execution/1 304.1±1.21ms 304.3±1.35ms +0.07%
vm/transaction_execution/10 96.2±1.31ms 95.9±0.49ms -0.31%
vm/transaction_execution/20 89.4±0.47ms 89.8±0.88ms +0.45%
vm/transaction_execution/5 117.1±1.04ms 118.0±3.99ms +0.77%
vm/transaction_execution/50 103.9±0.17ms 104.3±0.22ms +0.38%

@nkysg nkysg merged commit 4d73352 into master Mar 8, 2023
@nkysg nkysg deleted the update_proxima.yaml branch March 8, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants