Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mpm package new Move.toml and fix mpm release #3872

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Mar 14, 2023

mpm package new hello

change Move.toml.

previous mpm version 1.12.5, print output

[package]
name = "hello"
version = "0.0.0"

we want to change it

[package]
name = "hello"
version = "0.0.0"

[dependencies]
StarcoinFramework = { git = "https://github.com/starcoinorg/starcoin-framework.git", rev = "main" }

[addresses]
StarcoinFramework =  "0x1"

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): change Move.toml

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from nanne007 as a code owner March 14, 2023 06:06
@nkysg nkysg removed the request for review from nanne007 March 14, 2023 06:14
@nkysg nkysg changed the title fix move package new change move package new Mar 14, 2023
@github-actions
Copy link

Benchmark for 4f271f8

Click to view benchmark
Test Base PR %
accumulator_append 600.4±29.93µs 603.2±30.76µs +0.47%
block_apply/block_apply_10 257.5±0.40ms 257.9±0.34ms +0.16%
block_apply/block_apply_1000 26.5±0.02s 26.7±0.05s +0.75%
get_with_proof/db_store 36.3±0.21µs 36.7±0.22µs +1.10%
get_with_proof/mem_store 31.6±0.14µs 31.8±0.23µs +0.63%
put_and_commit/db_store/1 95.2±4.76µs 95.2±4.85µs 0.00%
put_and_commit/db_store/10 853.8±38.94µs 849.1±39.94µs -0.55%
put_and_commit/db_store/100 7.3±0.28ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 437.3±20.85µs 437.4±21.36µs +0.02%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.15ms 0.00%
put_and_commit/mem_store/1 61.6±5.70µs 61.7±5.63µs +0.16%
put_and_commit/mem_store/10 577.0±47.56µs 581.6±48.95µs +0.80%
put_and_commit/mem_store/100 5.7±0.84ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 291.9±24.79µs 293.6±25.90µs +0.58%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.13ms 3.8±0.11ms -2.56%
query_block/query_block_in(10)_times(1000) 37.9±0.82ms 38.2±0.69ms +0.79%
query_block/query_block_in(10)_times(10000) 383.4±6.95ms 384.6±8.42ms +0.31%
query_block/query_block_in(1000)_times(100) 951.7±5.22µs 977.9±8.46µs +2.75%
query_block/query_block_in(1000)_times(1000) 9.6±0.09ms 9.8±0.21ms +2.08%
query_block/query_block_in(1000)_times(10000) 95.6±0.56ms 96.7±0.97ms +1.15%
storage_transaction 1156.9±383.39µs 1126.0±371.35µs -2.67%
vm/transaction_execution/1 302.6±0.35ms 305.1±1.46ms +0.83%
vm/transaction_execution/10 95.5±0.90ms 95.4±0.19ms -0.10%
vm/transaction_execution/20 89.2±0.42ms 89.3±0.31ms +0.11%
vm/transaction_execution/5 116.1±0.43ms 117.7±4.19ms +1.38%
vm/transaction_execution/50 104.3±2.13ms 104.2±0.64ms -0.10%

@nkysg nkysg enabled auto-merge (squash) March 16, 2023 02:03
@nkysg nkysg requested review from sanlee42 and welbon March 16, 2023 02:03
@nkysg nkysg changed the title change move package new change move package new Move.toml Mar 16, 2023
@nkysg nkysg changed the title change move package new Move.toml change mpm package new Move.toml Mar 16, 2023
@nkysg nkysg changed the title change mpm package new Move.toml change mpm package new Move.toml and fix mpm release Mar 17, 2023
@nkysg nkysg requested a review from jackzhhuang March 17, 2023 08:35
@nkysg nkysg merged commit 9e45d45 into master Mar 17, 2023
@nkysg nkysg deleted the fix_mpm_package_new branch March 17, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants