change the rust version from 1.64.0 to 1.66.0 #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzhhuang
requested review from
jolestar,
nanne007 and
templexxx
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3874 +/- ##
==========================================
+ Coverage 53.77% 53.89% +0.13%
==========================================
Files 616 616
Lines 67796 67804 +8
==========================================
+ Hits 36448 36536 +88
+ Misses 31348 31268 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closed
sanlee42
force-pushed
the
update_to_1.65.0
branch
2 times, most recently
from
b999b4c to
e88f9b0
Compare
Benchmark for 950bbb9Click to view benchmark
|
jackzhhuang
force-pushed
the
update_to_1.65.0
branch
from
d4d6614 to
a049465
Compare
Benchmark for 83c6837Click to view benchmark
|
nkysg
removed request for
jolestar,
nanne007,
yourmoonlight,
templexxx and
LemonHX
nkysg
reviewed
Mar 21, 2023
| @@ -672,7 +672,7 @@ impl<'d> serde::de::DeserializeSeed<'d> for &TypeInstantiation { | |||
| T::Vector(layout) => Ok(match layout.as_ref() { | |||
| T::U8 => { | |||
| let bytes = <Vec<u8>>::deserialize(deserializer)?; | |||
| V::String(format!("0x{}", hex::encode(&bytes))) | |||
| V::String(format!("0x{}", hex::encode(bytes))) | |||
There was a problem hiding this comment.
这里应该是因为bytes是Vec，而Vec本来就已经实现了AsRef这个trait，因此不需要&bytes，直接bytes传过去就好。
nkysg
approved these changes
Mar 21, 2023
nkysg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information