Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move unittest error #3878

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix move unittest error #3878

merged 1 commit into from
Mar 22, 2023

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Mar 22, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@welbon welbon requested a review from nanne007 as a code owner March 22, 2023 14:39
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #3878 (5bdb4ac) into master (4856e37) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3878      +/-   ##
==========================================
- Coverage   53.93%   53.88%   -0.05%     
==========================================
  Files         616      616              
  Lines       67807    67807              
==========================================
- Hits        36565    36529      -36     
- Misses      31242    31278      +36     
Flag Coverage Δ
unittests 53.88% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/vm-runtime/src/natives.rs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4856e37...5bdb4ac. Read the comment docs.

@github-actions
Copy link

Benchmark for 8d6b760

Click to view benchmark
Test Base PR %
accumulator_append 603.4±26.62µs 607.0±29.97µs +0.60%
block_apply/block_apply_10 272.7±0.51ms 273.0±1.75ms +0.11%
block_apply/block_apply_1000 28.2±0.03s 28.1±0.02s -0.35%
get_with_proof/db_store 36.1±0.24µs 36.6±0.56µs +1.39%
get_with_proof/mem_store 31.5±0.24µs 31.4±0.18µs -0.32%
put_and_commit/db_store/1 95.7±4.78µs 95.9±5.60µs +0.21%
put_and_commit/db_store/10 855.1±39.73µs 857.7±39.33µs +0.30%
put_and_commit/db_store/100 7.4±0.29ms 7.4±0.31ms 0.00%
put_and_commit/db_store/5 439.6±30.86µs 442.2±22.35µs +0.59%
put_and_commit/db_store/50 3.9±0.17ms 3.8±0.17ms -2.56%
put_and_commit/mem_store/1 61.8±5.67µs 61.8±5.64µs 0.00%
put_and_commit/mem_store/10 580.6±49.51µs 581.8±48.84µs +0.21%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 293.1±25.49µs 293.9±26.23µs +0.27%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.15ms 3.9±0.08ms 0.00%
query_block/query_block_in(10)_times(1000) 38.5±0.57ms 38.6±0.98ms +0.26%
query_block/query_block_in(10)_times(10000) 388.4±7.28ms 388.4±8.46ms 0.00%
query_block/query_block_in(1000)_times(100) 1004.9±7.60µs 976.2±5.39µs -2.86%
query_block/query_block_in(1000)_times(1000) 10.0±0.07ms 9.8±0.07ms -2.00%
query_block/query_block_in(1000)_times(10000) 100.0±0.52ms 97.5±0.82ms -2.50%
storage_transaction 1158.0±401.02µs 992.6±310.11µs -14.28%
vm/transaction_execution/1 318.1±0.73ms 319.9±0.99ms +0.57%
vm/transaction_execution/10 99.2±0.78ms 99.3±0.34ms +0.10%
vm/transaction_execution/20 92.6±0.74ms 93.1±0.88ms +0.54%
vm/transaction_execution/5 121.3±0.68ms 121.8±0.44ms +0.41%
vm/transaction_execution/50 107.1±0.38ms 107.7±1.27ms +0.56%

@nkysg nkysg requested review from nkysg and removed request for nanne007 March 22, 2023 23:29
@nkysg nkysg requested review from jackzhhuang and sanlee42 March 22, 2023 23:31
@nkysg nkysg enabled auto-merge (squash) March 22, 2023 23:36
@nkysg nkysg merged commit 9376259 into master Mar 22, 2023
@nkysg nkysg deleted the fix_move_unittest_module branch March 22, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants