-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add upload file any size #3883
add upload file any size #3883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3883 +/- ##
==========================================
- Coverage 53.94% 53.73% -0.20%
==========================================
Files 616 616
Lines 67809 67809
==========================================
- Hits 36570 36433 -137
- Misses 31239 31376 +137
Flags with carried forward coverage won't be shown. Click here to find out more. see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
TypeError: upload_file_big_file() takes 2 positional arguments but 3 were given you can test jump server dir /temp_mount_for_sync_snapshot/barnard/put.sh |
def upload_file_any_size(file_name, bucket, key): | ||
file_size = os.path.getsize(file_name) | ||
if file_size > PER_UPLOADING: | ||
upload_file_big_file(file_name, bucket, key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是三个参数, 20行是2个参数,好像有问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我改好了, 现在可以了,你可以试试,key那个参数是后来加的
LGTM |
Benchmark for 5e2fb57Click to view benchmark
|
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information