Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force deploy #4025

Merged
merged 62 commits into from
Apr 17, 2024
Merged

Force deploy #4025

merged 62 commits into from
Apr 17, 2024

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Apr 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Update v11 stdlib blob with v6 move language version
  • Update test/dev network genesis to using stdlib v11
  • Force upgrade stdlib from v11 to v12 to fix hacking issues

Other information

@welbon welbon requested review from jolestar and nkysg as code owners April 10, 2024 12:12
@nkysg nkysg requested review from sanlee42, simonjiao and jackzhhuang and removed request for jolestar April 10, 2024 12:13
chain/open-block/src/lib.rs Outdated Show resolved Hide resolved
chain/src/chain.rs Outdated Show resolved Hide resolved
chain/src/chain.rs Outdated Show resolved Hide resolved
simonjiao and others added 6 commits April 14, 2024 15:30
1. dont print extra txn body to log file
2. silence a warning
1. Remove framework deposit logic
2. Update halley genesis timestamp for genesis block
3. Update block number of force upgrade to 400 to prevent too long
@welbon welbon requested a review from yourmoonlight as a code owner April 14, 2024 14:41
welbon added 2 commits April 14, 2024 22:42
 Update block number of force upgrade to 300 to prevent too long
1. change it to 15
2. update test cases
1. restore moduleUpgradeStrategy properly
2. update some suicide logs
1. update force upgrade height to 50 for test network
2. update test cases
Copy link

Benchmark for 1337b0d

Click to view benchmark
Test Base PR %
accumulator_append 981.5±194.81µs 905.7±148.84µs -7.72%
block_apply/block_apply_10 742.2±120.51ms 412.6±32.09ms -44.41%
block_apply/block_apply_1000 76.4±1.58s 44.7±0.76s -41.49%
get_with_proof/db_store 56.5±13.54µs 50.8±4.58µs -10.09%
get_with_proof/mem_store 48.3±10.61µs 43.3±6.55µs -10.35%
put_and_commit/db_store/1 136.8±12.44µs 125.1±11.25µs -8.55%
put_and_commit/db_store/10 1196.5±75.80µs 1177.0±95.15µs -1.63%
put_and_commit/db_store/100 10.5±0.46ms 12.4±2.81ms +18.10%
put_and_commit/db_store/5 807.0±158.46µs 748.1±137.75µs -7.30%
put_and_commit/db_store/50 7.1±0.89ms 6.7±1.35ms -5.63%
put_and_commit/mem_store/1 92.0±17.42µs 84.5±10.75µs -8.15%
put_and_commit/mem_store/10 936.7±191.32µs 766.0±99.00µs -18.22%
put_and_commit/mem_store/100 7.3±0.75ms 7.0±0.48ms -4.11%
put_and_commit/mem_store/5 391.8±60.63µs 384.3±60.60µs -1.91%
put_and_commit/mem_store/50 3.8±0.62ms 3.7±0.46ms -2.63%
query_block/query_block_in(10)_times(100) 6.1±0.49ms 5.2±0.78ms -14.75%
query_block/query_block_in(10)_times(1000) 67.4±11.68ms 48.7±2.37ms -27.74%
query_block/query_block_in(10)_times(10000) 585.4±26.17ms 492.0±21.59ms -15.95%
query_block/query_block_in(1000)_times(100) 1634.8±108.81µs 1494.4±46.82µs -8.59%
query_block/query_block_in(1000)_times(1000) 14.4±0.92ms 13.7±0.29ms -4.86%
query_block/query_block_in(1000)_times(10000) 197.5±36.97ms 144.9±8.41ms -26.63%
storage_transaction 1274.6±561.38µs 1333.5±704.25µs +4.62%
vm/transaction_execution/1 777.1±80.27ms 466.8±47.53ms -39.93%
vm/transaction_execution/10 217.6±15.10ms 142.7±6.10ms -34.42%
vm/transaction_execution/20 209.1±20.03ms 153.0±15.50ms -26.83%
vm/transaction_execution/5 275.8±18.02ms 187.8±14.82ms -31.91%
vm/transaction_execution/50 212.6±17.96ms 159.3±10.95ms -25.07%

Copy link

Benchmark for d75251e

Click to view benchmark
Test Base PR %
accumulator_append 920.7±140.17µs 1024.4±264.58µs +11.26%
block_apply/block_apply_10 749.9±82.18ms 389.5±5.27ms -48.06%
block_apply/block_apply_1000 77.2±1.73s 48.0±1.19s -37.82%
get_with_proof/db_store 51.1±4.39µs 52.1±6.87µs +1.96%
get_with_proof/mem_store 49.0±9.95µs 50.8±9.10µs +3.67%
put_and_commit/db_store/1 144.9±31.40µs 132.9±18.13µs -8.28%
put_and_commit/db_store/10 1235.3±241.32µs 1129.9±68.90µs -8.53%
put_and_commit/db_store/100 11.4±1.42ms 10.7±1.08ms -6.14%
put_and_commit/db_store/5 611.0±71.63µs 629.4±58.69µs +3.01%
put_and_commit/db_store/50 6.6±0.85ms 6.5±1.32ms -1.52%
put_and_commit/mem_store/1 77.9±4.94µs 81.1±9.39µs +4.11%
put_and_commit/mem_store/10 836.7±163.75µs 803.7±143.33µs -3.94%
put_and_commit/mem_store/100 7.2±0.82ms 7.1±0.44ms -1.39%
put_and_commit/mem_store/5 367.2±37.27µs 378.9±46.66µs +3.19%
put_and_commit/mem_store/50 3.8±0.75ms 3.7±0.43ms -2.63%
query_block/query_block_in(10)_times(100) 6.7±0.75ms 5.0±0.36ms -25.37%
query_block/query_block_in(10)_times(1000) 60.3±2.91ms 49.9±2.69ms -17.25%
query_block/query_block_in(10)_times(10000) 686.9±87.37ms 552.1±117.09ms -19.62%
query_block/query_block_in(1000)_times(100) 1631.2±214.08µs 1427.3±74.43µs -12.50%
query_block/query_block_in(1000)_times(1000) 14.3±0.58ms 14.5±1.00ms +1.40%
query_block/query_block_in(1000)_times(10000) 151.6±7.89ms 148.4±10.62ms -2.11%
storage_transaction 1266.1±655.01µs 1167.0±509.23µs -7.83%
vm/transaction_execution/1 832.7±108.77ms 458.0±34.62ms -45.00%
vm/transaction_execution/10 210.8±11.46ms 147.2±6.06ms -30.17%
vm/transaction_execution/20 194.7±15.59ms 152.0±7.72ms -21.93%
vm/transaction_execution/5 285.5±24.43ms 209.2±10.98ms -26.73%
vm/transaction_execution/50 205.5±12.97ms 155.5±7.41ms -24.33%

Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonjiao simonjiao merged commit 654d6d9 into master Apr 17, 2024
3 of 5 checks passed
@simonjiao simonjiao deleted the force_deploy branch April 17, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants