-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force deploy #4025
Merged
Merged
Force deploy #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on modifications of the starcoin-runtime layer
nkysg
requested review from
sanlee42,
simonjiao and
jackzhhuang
and removed request for
jolestar
April 10, 2024 12:13
nkysg
reviewed
Apr 10, 2024
nkysg
reviewed
Apr 10, 2024
nkysg
reviewed
Apr 10, 2024
nkysg
reviewed
Apr 10, 2024
nkysg
reviewed
Apr 10, 2024
nkysg
reviewed
Apr 10, 2024
1. dont print extra txn body to log file 2. silence a warning
1. Remove framework deposit logic 2. Update halley genesis timestamp for genesis block 3. Update block number of force upgrade to 400 to prevent too long
Update block number of force upgrade to 300 to prevent too long
1. change it to 15 2. update test cases
1. restore moduleUpgradeStrategy properly 2. update some suicide logs
1. update force upgrade height to 50 for test network 2. update test cases
Benchmark for 1337b0dClick to view benchmark
|
Benchmark for d75251eClick to view benchmark
|
simonjiao
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information