Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexiDag] update genesis files for halley/proxima #4113

Merged
merged 1 commit into from
May 24, 2024

Conversation

simonjiao
Copy link
Collaborator

  • fix init_scripts for stdlib 12

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested a review from jolestar as a code owner May 23, 2024 10:34
@simonjiao simonjiao requested review from sanlee42, welbon, nkysg and jackzhhuang and removed request for jolestar May 23, 2024 10:34
@simonjiao simonjiao marked this pull request as draft May 23, 2024 12:47
Copy link

Benchmark for c059d27

Click to view benchmark
Test Base PR %
accumulator_append 747.1±50.42µs 864.5±163.44µs +15.71%
block_apply/block_apply_10 386.8±55.68ms 371.7±16.77ms -3.90%
block_apply/block_apply_1000 37.2±0.77s 38.3±0.85s +2.96%
get_with_proof/db_store 45.2±1.39µs 45.3±1.04µs +0.22%
get_with_proof/mem_store 37.0±1.68µs 38.1±1.78µs +2.97%
put_and_commit/db_store/1 118.0±11.00µs 118.6±13.98µs +0.51%
put_and_commit/db_store/10 1020.3±45.12µs 1056.6±105.51µs +3.56%
put_and_commit/db_store/100 9.8±0.43ms 9.4±0.69ms -4.08%
put_and_commit/db_store/5 535.2±26.26µs 591.9±74.66µs +10.59%
put_and_commit/db_store/50 5.0±0.35ms 5.0±0.51ms 0.00%
put_and_commit/mem_store/1 73.1±7.04µs 72.0±6.19µs -1.50%
put_and_commit/mem_store/10 707.9±97.07µs 707.0±114.76µs -0.13%
put_and_commit/mem_store/100 6.6±0.43ms 6.5±0.38ms -1.52%
put_and_commit/mem_store/5 340.4±28.30µs 387.2±118.69µs +13.75%
put_and_commit/mem_store/50 3.2±0.13ms 3.2±0.15ms 0.00%
query_block/query_block_in(10)_times(100) 5.0±0.64ms 4.7±0.14ms -6.00%
query_block/query_block_in(10)_times(1000) 45.8±1.30ms 46.2±2.16ms +0.87%
query_block/query_block_in(10)_times(10000) 464.7±22.60ms 472.0±20.05ms +1.57%
query_block/query_block_in(1000)_times(100) 1183.8±51.24µs 1122.1±17.49µs -5.21%
query_block/query_block_in(1000)_times(1000) 11.8±0.20ms 11.2±0.13ms -5.08%
query_block/query_block_in(1000)_times(10000) 116.9±1.22ms 117.2±5.76ms +0.26%
storage_transaction 1112.8±460.26µs 1105.4±461.02µs -0.66%
vm/transaction_execution/1 407.0±9.64ms 434.9±21.02ms +6.86%
vm/transaction_execution/10 135.0±6.25ms 141.5±9.57ms +4.81%
vm/transaction_execution/20 137.8±16.42ms 131.4±11.40ms -4.64%
vm/transaction_execution/5 169.1±16.28ms 167.0±9.42ms -1.24%
vm/transaction_execution/50 144.6±5.96ms 146.6±9.29ms +1.38%

* avoid failure when creating block
* fix init_scripts for stdlib 12
* add tests for halley/proxima
* fix config test
@simonjiao simonjiao force-pushed the fix-generated-genesis branch from 4849eb3 to 564be3b Compare May 23, 2024 13:42
@simonjiao simonjiao marked this pull request as ready for review May 23, 2024 13:47
@simonjiao simonjiao changed the title update genesis files for halley/proxima [FlexiDag] update genesis files for halley/proxima May 23, 2024
Copy link

Benchmark for 405325a

Click to view benchmark
Test Base PR %
accumulator_append 787.3±123.71µs 782.9±113.10µs -0.56%
block_apply/block_apply_10 360.6±17.27ms 353.2±3.32ms -2.05%
block_apply/block_apply_1000 38.0±0.92s 38.6±1.73s +1.58%
get_with_proof/db_store 46.8±5.07µs 44.9±0.92µs -4.06%
get_with_proof/mem_store 36.7±1.13µs 37.1±1.32µs +1.09%
put_and_commit/db_store/1 119.0±12.91µs 118.9±11.26µs -0.08%
put_and_commit/db_store/10 1004.0±52.83µs 1024.9±50.36µs +2.08%
put_and_commit/db_store/100 9.3±0.32ms 9.6±0.34ms +3.23%
put_and_commit/db_store/5 569.8±74.27µs 559.3±81.31µs -1.84%
put_and_commit/db_store/50 4.9±0.32ms 5.0±0.40ms +2.04%
put_and_commit/mem_store/1 72.2±6.19µs 72.5±6.19µs +0.42%
put_and_commit/mem_store/10 691.2±82.08µs 672.6±58.45µs -2.69%
put_and_commit/mem_store/100 6.5±0.40ms 8.1±2.26ms +24.62%
put_and_commit/mem_store/5 336.6±27.51µs 351.2±41.72µs +4.34%
put_and_commit/mem_store/50 3.3±0.26ms 3.4±0.44ms +3.03%
query_block/query_block_in(10)_times(100) 4.5±0.13ms 4.6±0.13ms +2.22%
query_block/query_block_in(10)_times(1000) 46.0±1.61ms 45.3±1.86ms -1.52%
query_block/query_block_in(10)_times(10000) 460.3±13.27ms 451.8±8.45ms -1.85%
query_block/query_block_in(1000)_times(100) 1156.1±19.44µs 1187.0±42.40µs +2.67%
query_block/query_block_in(1000)_times(1000) 11.9±0.40ms 11.7±0.22ms -1.68%
query_block/query_block_in(1000)_times(10000) 116.1±1.91ms 117.6±1.31ms +1.29%
storage_transaction 1060.6±388.52µs 1152.4±494.98µs +8.66%
vm/transaction_execution/1 414.8±13.29ms 415.9±13.21ms +0.27%
vm/transaction_execution/10 129.2±5.46ms 132.4±5.83ms +2.48%
vm/transaction_execution/20 122.9±5.73ms 120.7±4.53ms -1.79%
vm/transaction_execution/5 177.9±23.27ms 168.2±9.05ms -5.45%
vm/transaction_execution/50 135.8±7.47ms 143.4±8.79ms +5.60%

@simonjiao simonjiao merged commit 8438ed4 into dag-master May 24, 2024
4 of 5 checks passed
@simonjiao simonjiao deleted the fix-generated-genesis branch May 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants