Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexiDag] remove some proxima-compatible codes #4115

Merged
merged 1 commit into from
May 27, 2024

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested a review from nkysg as a code owner May 24, 2024 05:55
@simonjiao simonjiao changed the title remove some proxima-compatible codes [FlexiDag] remove some proxima-compatible codes May 24, 2024
Copy link

Benchmark for 146b155

Click to view benchmark
Test Base PR %
accumulator_append 1231.4±193.93µs 1320.5±158.12µs +7.24%
block_apply/block_apply_10 513.1±42.50ms 595.8±23.16ms +16.12%
block_apply/block_apply_1000 61.0±1.41s 60.8±3.57s -0.33%
get_with_proof/db_store 95.5±0.99µs 72.5±12.81µs -24.08%
get_with_proof/mem_store 60.4±7.80µs 54.6±6.26µs -9.60%
put_and_commit/db_store/1 201.2±22.80µs 232.1±17.98µs +15.36%
put_and_commit/db_store/10 1963.5±69.21µs 1851.7±116.56µs -5.69%
put_and_commit/db_store/100 14.3±1.88ms 14.6±1.80ms +2.10%
put_and_commit/db_store/5 894.8±90.85µs 868.7±101.66µs -2.92%
put_and_commit/db_store/50 7.8±1.56ms 7.9±0.67ms +1.28%
put_and_commit/mem_store/1 109.7±19.57µs 112.3±27.75µs +2.37%
put_and_commit/mem_store/10 986.0±195.51µs 1079.4±131.46µs +9.47%
put_and_commit/mem_store/100 10.3±1.58ms 9.7±1.61ms -5.83%
put_and_commit/mem_store/5 477.2±75.70µs 583.2±66.36µs +22.21%
put_and_commit/mem_store/50 5.1±0.78ms 6.8±0.04ms +33.33%
query_block/query_block_in(10)_times(100) 6.6±0.55ms 6.6±0.98ms 0.00%
query_block/query_block_in(10)_times(1000) 66.8±7.74ms 66.3±7.05ms -0.75%
query_block/query_block_in(10)_times(10000) 830.5±127.40ms 726.6±77.36ms -12.51%
query_block/query_block_in(1000)_times(100) 1734.9±211.67µs 2.2±0.24ms +26.81%
query_block/query_block_in(1000)_times(1000) 17.6±2.63ms 19.4±1.75ms +10.23%
query_block/query_block_in(1000)_times(10000) 228.4±7.02ms 221.0±18.14ms -3.24%
storage_transaction 1725.2±743.47µs 1400.1±481.00µs -18.84%
vm/transaction_execution/1 549.6±65.65ms 662.4±35.05ms +20.52%
vm/transaction_execution/10 188.9±14.10ms 186.7±12.28ms -1.16%
vm/transaction_execution/20 173.9±8.67ms 162.1±11.50ms -6.79%
vm/transaction_execution/5 247.4±28.44ms 223.9±16.13ms -9.50%
vm/transaction_execution/50 204.6±14.09ms 203.1±8.76ms -0.73%

@simonjiao simonjiao merged commit 3180971 into dag-master May 27, 2024
4 of 5 checks passed
@simonjiao simonjiao deleted the fix-proxima-related-codes branch May 27, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants