Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use upload-artifact v4 #4332

Merged
merged 1 commit into from
Dec 9, 2024
Merged

use upload-artifact v4 #4332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release_asset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
run: bash ./scripts/release_mpm.sh ${{ matrix.platform }}

- name: upload artifact asset
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Upgrade related actions for consistency and security

The verification confirms that both related actions have newer versions available:

  • actions/checkout is at v4.2.2 (current: v2)
  • actions/upload-release-asset has been deprecated in favor of @softprops/action-gh-release

Consider:

  • Upgrading actions/checkout@v2 to v4
  • Replacing actions/upload-release-asset@v1 with @softprops/action-gh-release
🔗 Analysis chain

Consider upgrading related actions for consistency

While upgrading to upload-artifact@v4 is good, other actions in the workflow are using older versions. Consider:

  • Upgrading actions/checkout@v2 to v4
  • Upgrading actions/upload-release-asset@v1 to the latest version
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check the latest versions of the GitHub Actions being used
gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/actions/checkout/releases/latest

gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/actions/upload-release-asset/releases/latest

Length of output: 4666

if: ${{ github.event_name != 'release'}}
with:
name: starcoin-${{ matrix.platform }}.zip
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
run: bash ./scripts/release_mpm.sh 'ubuntu-18.04'

- name: upload artifact asset
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ github.event_name != 'release'}}
with:
name: starcoin-ubuntu-18.04.zip
Expand Down
Loading