Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: remove inferior <-> index circular dependencies #1148

Merged
merged 6 commits into from
Apr 2, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Apr 1, 2019

This PR removes all circular dependencies in the repo that has the following pattern:

inferior.js -> ... -> index.js (which exports inferior.js) ... -> inferior.js

Fixes #1065 (the cause of the issue).

TODO

  • make sure CI will reliably verify the absence of these problems for the client

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1148   +/-   ##
======================================
  Coverage    82.4%   82.4%           
======================================
  Files         733     733           
  Lines        8717    8717           
  Branches     1165    1165           
======================================
  Hits         7183    7183           
  Misses       1519    1519           
  Partials       15      15
Impacted Files Coverage Δ
packages/react/src/components/Ref/RefForward.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Ref/RefFindNode.tsx 100% <100%> (ø) ⬆️
packages/react/src/lib/renderComponent.tsx 92.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830d15f...4f627e6. Read the comment docs.

@kuzhelov kuzhelov merged commit 84263f0 into master Apr 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/circular-dependency-on-index branch April 2, 2019 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants