Refactor SSE data lines creation #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent conversation on the Discord mentioned SSE event injection. The way to mitigate this is to split the text that will make the data part of SSE events on end of lines and prefix each line with
"data: ". Currently that line splitting is done in each patch function (patch-elements, patch-elements-seq, patch-signals).In this PR I centralized this line splitting in the one function every patch function depends on and I changed the use of
clojure.string/split-lineswith a custom function that makes use ofString/.lines.In short, I centralized the line splitting in one place to make sure its mandatory and I optimized the process a bit (especially for text with a lot of EOL).
Cheers,