Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick cypher support #463

Merged

Conversation

xhtian95
Copy link

cherry pick cypherapi, and make small changes to support query under different graphspaces.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #463 (5e5a811) into gh-dis-release (9667b3e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@                 Coverage Diff                  @@
##             gh-dis-release     #463      +/-   ##
====================================================
- Coverage             35.31%   35.29%   -0.02%     
  Complexity             4345     4345              
====================================================
  Files                   445      447       +2     
  Lines                 38518    38549      +31     
  Branches               5303     5305       +2     
====================================================
+ Hits                  13602    13606       +4     
- Misses                23262    23288      +26     
- Partials               1654     1655       +1     
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/api/gremlin/CypherAPI.java 0.00% <0.00%> (ø)
...va/com/baidu/hugegraph/api/gremlin/GremlinAPI.java 0.00% <0.00%> (ø)
...m/baidu/hugegraph/api/gremlin/GremlinQueryAPI.java 0.00% <0.00%> (ø)
...n/java/com/baidu/hugegraph/version/ApiVersion.java 0.00% <0.00%> (ø)
...va/com/baidu/hugegraph/backend/cache/RamCache.java 44.38% <0.00%> (-0.57%) ⬇️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.42% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9667b3e...5e5a811. Read the comment docs.

* version 0.13:
* [0.67] Issue-11: hugegraph with etcd/pd,
* add graphspace, remove auth server
* [0.68] Issue-1763: Support adamic-adar & resource-allocation API
* [0.68] Issue-1763: Support adamic-adar & resource-allocation API
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete duplicated line

@PathParam("graphspace") String graphspace,
@PathParam("graph") String graph,
@QueryParam("cypher") String cypher
) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 37

return transformResponseIfNeeded(response);
}

private String translateCpyher2Gremlin(String cypher) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "cypher"

@@ -0,0 +1,88 @@
/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add CypherApiTest into ApiTestSuite to run tests

@xhtian95 xhtian95 force-pushed the cherry_pick_cypher_support branch from 4a95597 to 5e5a811 Compare June 17, 2022 06:45
@zhoney zhoney merged commit 66520ce into starhugegraph:gh-dis-release Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants