-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate maxTotalBalance #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarmitKl
changed the title
feat: popup-alert on maxTotalBalance
feat: popup error alert on maxTotalBalance
Mar 27, 2022
@CarmitKl please change the PR title to |
CarmitKl
changed the title
feat: popup error alert on maxTotalBalance
feat: validate maxTotalBalance
Mar 27, 2022
dan-ziv
reviewed
Mar 27, 2022
dan-ziv
reviewed
Mar 27, 2022
dan-ziv
reviewed
Mar 27, 2022
dan-ziv
reviewed
Mar 27, 2022
@CarmitKl Please add |
CarmitKl
added
in progress
Pull request is still a work in progress
and removed
ready for review
Pull request is ready to be reviewed
labels
Mar 27, 2022
… into feat/noteOnMaxTotalBalance
…ware-libs/starknet-bridge into feat/noteOnMaxTotalBalance
…o feat/noteOnMaxTotalBalance
…o feat/noteOnMaxTotalBalance
🎉 This PR is included in version 0.1.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total value locked (TVL) in the bridge on L1 is limited for each token type: currently, the limit is $100k for each token.
So this PR adds the validation to prevent executing a transaction if the selectetToken will pass its 'maxTotalBalance' value.
If so- the user will see the error-modal with an appropriate explanation.
<type>(optional subject): <description>
, e.g:fix: minor typos in code
This change is