Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FAQ tab #106

Merged
merged 18 commits into from
Mar 28, 2022
Merged

feat: FAQ tab #106

merged 18 commits into from
Mar 28, 2022

Conversation

CarmitKl
Copy link

@CarmitKl CarmitKl commented Mar 28, 2022 •
edited
Loading

Add a new menuType: FAQ. It shows frequently asked questions. The link to it is from the Header.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the standard-version convention: <type>(optional subject): <description>, e.g: fix: minor typos in code

This change is Reviewable

@CarmitKl CarmitKl added the in progress Pull request is still a work in progress label Mar 28, 2022
@dan-ziv dan-ziv changed the base branch from dev to alpha March 28, 2022 07:12
@dan-ziv dan-ziv self-requested a review March 28, 2022 07:13
@CarmitKl
Copy link
Author

Still need to implement the links in the text. Also want to try to visually separate better between questions.

@CarmitKl CarmitKl added ready for review Pull request is ready to be reviewed and removed in progress Pull request is still a work in progress labels Mar 28, 2022
dan-ziv
dan-ziv requested changes Mar 28, 2022
View reviewed changes
@CarmitKl CarmitKl requested a review from dan-ziv March 28, 2022 11:49
dan-ziv
dan-ziv reviewed Mar 28, 2022
View reviewed changes
src/components/Features/Faq/Faq.module.scss Outdated
Comment on lines 66 to 69
& * {
position: relative;
z-index: 1;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what is this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to lift the text above the light-purple background that's behind the answers

@CarmitKl CarmitKl requested a review from dan-ziv March 28, 2022 12:19
@dan-ziv dan-ziv changed the title feat: add tab FAQ feat: FAQ tab Mar 28, 2022
@dan-ziv dan-ziv merged commit bdb823e into alpha Mar 28, 2022
@dan-ziv dan-ziv deleted the feat/TabFAQ branch March 28, 2022 14:41
@dan-ziv dan-ziv restored the feat/TabFAQ branch September 6, 2022 11:18
@dan-ziv dan-ziv deleted the feat/TabFAQ branch September 6, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees
No one assigned
Labels
ready for review Pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarmitKl @dan-ziv