Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboarding modal #109

Merged
merged 7 commits into from
Mar 29, 2022
Merged

feat: onboarding modal #109

merged 7 commits into from
Mar 29, 2022

Conversation

CarmitKl
Copy link

@CarmitKl CarmitKl commented Mar 29, 2022 •
edited
Loading

Add a new modal: OnboardingModal. It displays a warning & explanations regarding using the Alpha version of StarkGate.
It shows on the mount of the Bridge component (after login, when arriving to the bridge, or after refreshing it).
Timeout set to 24 hours.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the standard-version convention: <type>(optional subject): <description>, e.g: fix: minor typos in code

This change is Reviewable

@CarmitKl CarmitKl added the ready for review Pull request is ready to be reviewed label Mar 29, 2022
@CarmitKl CarmitKl requested a review from dan-ziv March 29, 2022 07:53
@CarmitKl CarmitKl added in progress Pull request is still a work in progress and removed ready for review Pull request is ready to be reviewed labels Mar 29, 2022
@CarmitKl CarmitKl changed the title feat: on boarding modal feat: Onboarding modal Mar 29, 2022
@dan-ziv dan-ziv changed the title feat: Onboarding modal feat: onboarding modal Mar 29, 2022
@CarmitKl CarmitKl changed the title feat: Onboarding modal feat: onboarding modal Mar 29, 2022
@CarmitKl CarmitKl changed the base branch from dev to alpha March 29, 2022 07:57
@CarmitKl CarmitKl added ready for review Pull request is ready to be reviewed and removed in progress Pull request is still a work in progress labels Mar 29, 2022
dan-ziv
dan-ziv requested changes Mar 29, 2022
View reviewed changes
src/__tests__/utils/date.spec.js Outdated Show resolved Hide resolved
src/__tests__/utils/date.spec.js Outdated Show resolved Hide resolved
src/components/Features/Bridge/Bridge.js Outdated Show resolved Hide resolved
src/components/Features/Bridge/Bridge.js Outdated Show resolved Hide resolved
src/components/Features/Bridge/Bridge.js Outdated Show resolved Hide resolved
src/components/Features/Bridge/Bridge.js Outdated Show resolved Hide resolved
src/utils/date.js Outdated Show resolved Hide resolved
src/utils/date.js Outdated Show resolved Hide resolved
src/config/envs.js Outdated Show resolved Hide resolved
@CarmitKl CarmitKl added in progress Pull request is still a work in progress and removed ready for review Pull request is ready to be reviewed labels Mar 29, 2022
@CarmitKl CarmitKl added the ready for review Pull request is ready to be reviewed label Mar 29, 2022
@CarmitKl CarmitKl requested a review from dan-ziv March 29, 2022 10:43
@CarmitKl CarmitKl removed the in progress Pull request is still a work in progress label Mar 29, 2022
@CarmitKl CarmitKl merged commit 76faa39 into alpha Mar 29, 2022
@CarmitKl CarmitKl deleted the feat/onBoardingModal branch March 29, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees
No one assigned
Labels
ready for review Pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarmitKl @dan-ziv