Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle chain changed #122

Merged
merged 3 commits into from
Apr 3, 2022
Merged

fix: handle chain changed #122

merged 3 commits into from
Apr 3, 2022

Conversation

CarmitKl
Copy link

@CarmitKl CarmitKl commented Apr 3, 2022

If the user is connected (via metamask) to an L1 chain that isn't found in the app's "ChainInfo",
The 'ChainUnsupportedError' will appear, just without adding the name of the used L1 chain.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the standard-version convention: <type>(optional subject): <description>, e.g: fix: minor typos in code

This change is Reviewable

@CarmitKl CarmitKl requested a review from dan-ziv April 3, 2022 09:49
@CarmitKl CarmitKl added the ready for review Pull request is ready to be reviewed label Apr 3, 2022
@CarmitKl CarmitKl changed the base branch from dev to alpha April 3, 2022 10:55
@CarmitKl CarmitKl merged commit 99cc823 into alpha Apr 3, 2022
@CarmitKl CarmitKl deleted the fix/handleChainChanged branch April 3, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants