Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty callback in promise .then #127

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Apr 4, 2022

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv changed the title fix: empty callback in promise then fix: empty callback in promise .then Apr 4, 2022
@dan-ziv dan-ziv merged commit 9d13c3b into dev Apr 4, 2022
@dan-ziv dan-ziv deleted the fix/empty-callback-in-promise-then branch April 4, 2022 08:29
dan-ziv pushed a commit that referenced this pull request Apr 4, 2022
 ## [1.0.0-dev.2](v1.0.0-dev.1...v1.0.0-dev.2) (2022-04-04)

### 🔧 Fixes

* empty callback in promise .then ([#127](#127)) ([9d13c3b](9d13c3b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 4, 2022

🎉 This PR is included in version 1.0.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 4, 2022
 ## [1.0.0](v0.0.1...v1.0.0) (2022-04-04)

### ⚠ BREAKING CHANGES

* alpha version (#126)

### 💉 Improvements

* utils ([#82](#82)) ([c38e56e](c38e56e))

### 🧩 Features

* alpha version ([#126](#126)) ([5b15ca0](5b15ca0))
* handle browser support  ([#96](#96)) ([56d920d](56d920d))
* remove redux and use providers ([#98](#98)) ([ed38ae4](ed38ae4))
* **toasts:** add link to transfer log ([#79](#79)) ([b743b85](b743b85))
* use blockNumber=pending for balanceOf calls ([#58](#58)) ([9a84b05](9a84b05))

### 🔧 Fixes

* add missing env poll block number interval ([d364cb4](d364cb4))
* empty callback in promise .then ([#127](#127)) ([9d13c3b](9d13c3b))
* **getTransactionHash:** add fee and version to calculation ([#90](#90)) ([938ffe0](938ffe0))
* redux error on switching menu "non-serializable value was detected" ([#89](#89)) ([9dc4972](9dc4972))
* remove pending transfer toast ([#92](#92)) ([20f51f3](20f51f3))
* update ETH token addresses and add SLF token ([#84](#84)) ([2c5a9df](2c5a9df))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 4, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dan-ziv dan-ziv restored the fix/empty-callback-in-promise-then branch September 6, 2022 11:18
@dan-ziv dan-ziv deleted the fix/empty-callback-in-promise-then branch September 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant