ci: add nginx configuration file for app routing #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibs/starkgate-frontend into guy/master/fix/nginx_routing
dan-ziv
approved these changes
Apr 12, 2022
dan-ziv
changed the title
alon-dotan-starkware
suggested changes
Apr 12, 2022
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware and @guyvelleman)
nginx.conf, line 1 at r2 (raw file):
server {
Place it under aome folder
files / config / some other name
nginx.conf, line 8 at r2 (raw file):
location / { root /usr/share/nginx/html; try_files $uri /index.html;
Replace tabs with spaces
|
🎉 This PR is included in version 1.2.0-dev.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
Apr 14, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Apr 14, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Apr 14, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Apr 14, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Checklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is