Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch asset to SN wallet #171

Merged
merged 9 commits into from
May 3, 2022
Merged

feat: watch asset to SN wallet #171

merged 9 commits into from
May 3, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented May 2, 2022

Description of the Changes

Request to add asset (i.e. token) to SN wallet after success deposit.
In case the token is already been added by our app, ignore the request for next time.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv changed the title feat: watch asset [WIP] feat: watch asset to SN wallet May 2, 2022
@dan-ziv dan-ziv requested a review from bbrandtom May 2, 2022 20:56
@dan-ziv dan-ziv merged commit 30d8ec3 into dev May 3, 2022
@dan-ziv dan-ziv deleted the feat/watch-asset branch May 3, 2022 21:11
dan-ziv pushed a commit that referenced this pull request May 3, 2022
 ## [1.4.0-dev.1](v1.3.1-dev.5...v1.4.0-dev.1) (2022-05-03)

### 🧩 Features

* add asset to SN wallet after a successful deposit ([#171](#171)) ([30d8ec3](30d8ec3))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 3, 2022

🎉 This PR is included in version 1.4.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 4, 2022
 ## [1.4.0](v1.3.0...v1.4.0) (2022-05-04)

### 🔧 Fixes

* cancel toFixed when format balances ([#172](#172)) ([2906e3e](2906e3e))
* connection modal overrides gsw selection modal ([#175](#175)) ([73b1f21](73b1f21))
* temporary disable max button ([#173](#173)) ([1d3038d](1d3038d))
* update app state on accountsChanged event ([#176](#176)) ([3161cc9](3161cc9))
* update text for the attempt to deposit more than the allowable amount ([#174](#174)) ([d8f3da8](d8f3da8))

### 🧩 Features

* add asset to SN wallet after a successful deposit ([#171](#171)) ([30d8ec3](30d8ec3))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 4, 2022

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dan-ziv dan-ziv restored the feat/watch-asset branch September 6, 2022 11:18
@dan-ziv dan-ziv deleted the feat/watch-asset branch September 6, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant