Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change transfer tabs names #182

Merged
merged 2 commits into from
May 11, 2022
Merged

fix: change transfer tabs names #182

merged 2 commits into from
May 11, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented May 11, 2022

Description of the Changes

Change tab names to StarkNet -> Ethereum instead of just Ethereum and vice versa.

image

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv requested a review from bbrandtom May 11, 2022 15:00
Copy link
Member

@bbrandtom bbrandtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: :lgtm: :lgtm: :lgtm: :lgtm: !!!!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-ziv)

Base automatically changed from feat/multi-choice-menu to dev May 11, 2022 17:18
@dan-ziv dan-ziv changed the title fix: tabs names fix: change transfer tabs names May 11, 2022
@dan-ziv dan-ziv merged commit e795f1c into dev May 11, 2022
@dan-ziv dan-ziv deleted the fix/tabs-names branch May 11, 2022 17:18
dan-ziv pushed a commit that referenced this pull request May 11, 2022
 ## [1.5.0-dev.1](v1.4.2-dev.2...v1.5.0-dev.1) (2022-05-11)

### 🧩 Features

* MultiChoiceMenu component ([#181](#181)) ([bbf19ba](bbf19ba))

### 🔧 Fixes

* change transfer tabs names ([#182](#182)) ([e795f1c](e795f1c))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 11, 2022

🎉 This PR is included in version 1.5.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 26, 2022
 ## [1.5.0](v1.4.0...v1.5.0) (2022-05-26)

### 🧩 Features

* add LayerSwap to liquidity providers ([#201](#201)) ([4f8aa97](4f8aa97))
* buy into L2 (fiat on ramp) + Banxa provider  ([#183](#183)) ([6df9b4d](6df9b4d))
* **DAI withdrawals:** call `increaseAllowance` before calling `initiate_withdraw` ([#200](#200)) ([7a2c284](7a2c284))
* lock bridge ([#198](#198)) ([4f433e6](4f433e6))
* move Terms and FAQ routes to burger menu ([#202](#202)) ([264b550](264b550))
* move the discord tab to a side button ([#199](#199)) ([0570a92](0570a92))
* MultiChoiceMenu component ([#181](#181)) ([bbf19ba](bbf19ba))

### 💉 Improvements

* export convention ([#180](#180)) ([b5585ad](b5585ad))
* promise handler instead of try/catch statement ([#209](#209)) ([1f56c38](1f56c38))
* terms screen ([#207](#207)) ([0feca18](0feca18))
* tokens addresses ([#178](#178)) ([c75a88a](c75a88a))

### 🔧 Fixes

* change transfer tabs names ([#182](#182)) ([e795f1c](e795f1c))
* CompleteTransferToL1 toast remains on display after tx is done ([#179](#179)) ([219b860](219b860))
* **GATE-2:** change documentation links on FAQ page ([#206](#206)) ([ec0741a](ec0741a))
* **GATE-5:** "Transfer in progress" popup doesn't close even after transaction is successful ([#210](#210)) ([4e11653](4e11653))
* **GATE-7:** Call 'ceiling' on DAI bridge instead of 'maxTotalBalance' ([#196](#196)) ([50a2780](50a2780))
* **GATE-9:** incorrect DAI amount ([#208](#208)) ([46b80bd](46b80bd))
* handle Discord button on scroll ([#205](#205)) ([5fdce7e](5fdce7e))
* **Header:** testnet title not displayed ([4169584](4169584))
* modal error messages not displayed ([#194](#194)) ([353c3b4](353c3b4))
* move EventManagerProvider to app-level ([#197](#197)) ([7fbd4fe](7fbd4fe))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 26, 2022

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dan-ziv dan-ziv restored the fix/tabs-names branch September 6, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants