fix: split getNonce interface

starknet-io · Nov 29, 2022 · 7b7acd9 · 7b7acd9
1 parent a91f623
commit 7b7acd9
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/__tests__/defaultProvider.test.ts b/__tests__/defaultProvider.test.ts
@@ -76,7 +76,7 @@ describe('defaultProvider', () => {
  });
 
  test('getNonce()', async () => {
- const nonce = await testProvider.getNonce(erc20ContractAddress);
+ const nonce = await testProvider.getNonceForAddress(erc20ContractAddress);
  return expect(toBN(nonce)).toEqual(toBN('0x0'));
  });
 

diff --git a/src/account/default.ts b/src/account/default.ts
@@ -53,7 +53,7 @@ export class Account extends Provider implements AccountInterface {
  }
 
  public async getNonce(blockIdentifier?: BlockIdentifier): Promise<BigNumberish> {
- return super.getNonce(this.address, blockIdentifier);
+ return super.getNonceForAddress(this.address, blockIdentifier);
  }
 
  public async estimateFee(

diff --git a/src/provider/default.ts b/src/provider/default.ts
@@ -104,11 +104,11 @@ export class Provider implements ProviderInterface {
  );
  }
 
- public async getNonce(
+ public async getNonceForAddress(
  contractAddress: string,
  blockIdentifier?: BlockIdentifier
  ): Promise<BigNumberish> {
- return this.provider.getNonce(contractAddress, blockIdentifier);
+ return this.provider.getNonceForAddress(contractAddress, blockIdentifier);
  }
 
  public async getStorageAt(

diff --git a/src/provider/interface.ts b/src/provider/interface.ts
@@ -98,7 +98,7 @@ export abstract class ProviderInterface {
  * @param contractAddress - contract address
  * @returns the hex nonce
  */
- public abstract getNonce(
+ public abstract getNonceForAddress(
  contractAddress: string,
  blockIdentifier?: BlockIdentifier
  ): Promise<BigNumberish>;

diff --git a/src/provider/rpc.ts b/src/provider/rpc.ts
@@ -132,7 +132,7 @@ export class RpcProvider implements ProviderInterface {
  });
  }
 
- public async getNonce(
+ public async getNonceForAddress(
  contractAddress: string,
  blockIdentifier: BlockIdentifier = 'pending'
  ): Promise<RPC.Nonce> {

diff --git a/src/provider/sequencer.ts b/src/provider/sequencer.ts
@@ -256,7 +256,7 @@ export class SequencerProvider implements ProviderInterface {
  );
  }
 
- public async getNonce(
+ public async getNonceForAddress(
  contractAddress: string,
  blockIdentifier: BlockIdentifier = 'pending'
  ): Promise<BigNumberish> {