Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bundle resolution, module, type import for walletaccount #1042

Merged
merged 4 commits into from
Mar 26, 2024
Merged

feat: bundle resolution, module, type import for walletaccount #1042

merged 4 commits into from
Mar 26, 2024

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Mar 26, 2024 •
edited
Loading

Motivation and Resolution

Resolve import Wallet Connect types (without extracting or changing get-starknet bundler)

  • get-starknet-core "^4.0.0-next.3"
  • moduleResolution: Bundler
  • module: ES2022

Usage related changes

None

Development related changes

None

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

penovicp
penovicp approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivpavici ivpavici mentioned this pull request Mar 26, 2024
Merged
6 tasks
@tabaktoni tabaktoni changed the base branch from develop to next-version March 26, 2024 18:33
@tabaktoni tabaktoni merged commit 99921b1 into next-version Mar 26, 2024
3 checks passed
@tabaktoni tabaktoni mentioned this pull request Mar 27, 2024
Merged
6 tasks
penovicp pushed a commit that referenced this pull request Apr 3, 2024
@tabaktoni @penovicp
feat: bundle resolution, module, type import for walletaccount (#1042)
d85c8b8 
* feat: bundle resolution, module, type import for walletaccount

* chore: fix connect import

* chore: add get-starknet-core next as dependencie

* chore: import fix
@penovicp penovicp deleted the v6/wallet-types branch April 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivpavici ivpavici ivpavici approved these changes

@penovicp penovicp penovicp approved these changes

@dhruvkelawala dhruvkelawala Awaiting requested review from dhruvkelawala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabaktoni @ivpavici @penovicp