refactor: update starknetid contract addr on sepolia & remove old code #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: fix transaction retry interval fallback for devnet tests * test: remove test.only
# [6.9.0](starknet-io/starknet.js@v6.8.0...v6.9.0) (2024-05-21) ### Bug Fixes * cannot infer ts2742 types from starknet-types@0.7 ([starknet-io#1098](starknet-io#1098)) ([f1c3b8e](starknet-io@f1c3b8e)) * remove [warning] from typedoc for external usage ([starknet-io#1095](starknet-io#1095)) ([195186f](starknet-io@195186f)), closes [starknet-io#1121](starknet-io#1121) [starknet-io#1126](starknet-io#1126) ### Features * add type coverage ([starknet-io#1120](starknet-io#1120)) ([eceda5d](starknet-io@eceda5d)) * provider.getL1MessageHash ([starknet-io#1123](starknet-io#1123)) ([1489cf2](starknet-io@1489cf2)) ### Reverts * Revert "chore: add examples to JsDoc for transaction.ts file (starknet-io#1105)" (starknet-io#1108) ([59eb01e](starknet-io@59eb01e)), closes [starknet-io#1105](starknet-io#1105) [starknet-io#1108](starknet-io#1108)
irisdv
changed the title
|
Hello, |
|
Should I base my PR on another branch then ? |
|
As it has been already reviewed, I think that PR#1133 will be merged soon by @ivpavici or @tabaktoni , in |
|
Closing this as I opened a new PR #1139 based on |
|
@irisdv hi and thanks! merged @PhilippeR26 's PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
This PR updates starknet ID contract addresses on Sepolia, and remove some code that was needed to ensure a smooth transition on a change we made to the
address_to_domainfunction in the naming contract.Checklist: