Skip to content

Conversation

@ivpavici
Copy link
Collaborator

Motivation and Resolution

Added getNonce endpoint for Sequencer, since this is added in Cairo lang 0.10

RPC version (if applicable)

...

Usage related changes

  • Change 1.
    Users can call the sequencer getNonce endpoint

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes
  • Updated the docs (www)
  • Updated the tests
  • All tests are passing

@ivpavici ivpavici requested a review from tabaktoni August 31, 2022 15:48
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit b6083d3
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/630f82bde60e800008f8c2fa

@ivpavici
Copy link
Collaborator Author

ivpavici commented Sep 1, 2022

Test fails because testnet is not updated yet with this endpoint

return this.provider.getEstimateFee(invocation, blockIdentifier, invocationDetails);
}

public async getNonce(contractAddress: string): Promise<any> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Promise<any> will change with a correct type in future?

@dhruvkelawala dhruvkelawala mentioned this pull request Sep 2, 2022
7 tasks
@ivpavici
Copy link
Collaborator Author

ivpavici commented Sep 6, 2022

Shall be merged together with #318

@ivpavici ivpavici closed this Sep 6, 2022
@ivpavici ivpavici deleted the ivpavici-get-nonce branch September 8, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants