Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix call response type & Signature type #570

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Mar 30, 2023

Motivation and Resolution

Fix TS issue with contract.call response
Signature #565

Usage related changes

Type-defined but more flexible Signature:
If used as string[] it can be any implementation and default implementation use WeierstrassSignatureType

Development-related changes

No interface changes just redefined types

export type WeierstrassSignatureType = weierstrass.SignatureType;
export type ArraySignatureType = string[];
export type AnySignatureType = string | number | ArraySignatureType | WeierstrassSignatureType;
export type Signature = ArraySignatureType | WeierstrassSignatureType;

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes
  • Updated the docs (www)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 44e3792
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/642ab82229be620008d9954f

@tabaktoni tabaktoni changed the title chore: fix call response type to generic object Result chore: fix call response type & Signature type Mar 30, 2023
@tabaktoni tabaktoni requested a review from dhruvkelawala April 3, 2023 10:54
@tabaktoni tabaktoni merged commit c6c42e0 into develop Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the fix/signature-type branch May 9, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants