Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FailedTransactionResponse #681

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix FailedTransactionResponse #681

merged 3 commits into from
Jul 12, 2023

Conversation

tabaktoni
Copy link
Collaborator

Motivation and Resolution

Added missing transaction_failure_reason as an optional prop on transaction response for Rejected Transactions.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 65b1ef4
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/64ad3e53150bb50008a9be50

@tabaktoni tabaktoni changed the base branch from develop to next-version July 12, 2023 08:24
@tabaktoni tabaktoni merged commit 9b67e23 into next-version Jul 12, 2023
6 of 8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 5.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the fix/transaction-response-type branch September 16, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivpavici ivpavici ivpavici approved these changes

@penovicp penovicp Awaiting requested review from penovicp

@dhruvkelawala dhruvkelawala Awaiting requested review from dhruvkelawala

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabaktoni @ivpavici