fix: optional keys and address in eventfilters #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next version
# [5.17.0](v5.16.0...v5.17.0) (2023-07-18) ### Bug Fixes * add FailedTransactionResponse ([994925e](994925e)) * remedy type declaration roll-up issues ([48625f4](48625f4)) * transaction_failure_reason ([77329b7](77329b7)) ### Features * add Enum in contract ([515e233](515e233)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1) * calldata result in populate ([d44dc56](d44dc56)), closes [#675](#675) [#1](#1) * contractFactory Cairo1 & changed constructor signature, 0.12 test fixes ([9b44c54](9b44c54)) * rename Failed to Rejected for transaction type ([65b1ef4](65b1ef4))
✅ Deploy Preview for starknetjs canceled.
|
penovicp
approved these changes
Jul 20, 2023
|
Originally we had as a specification sad none was required, I don't know why v4 set ti to required, but none of it should be required |
tabaktoni
reviewed
Jul 20, 2023
|
Could you finalize the PR? (I am in the train to Paris) |
I will do RPC 0.4 PR and deal with it, don't worry |
tabaktoni
approved these changes
Jul 27, 2023
|
🎉 This PR is included in version 5.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Solve issue #692
RPC version (if applicable)
In EVENT_FILTER, keys and address should be optional.
Usage related changes
Keys and Address filters are not mandatory.
Development related changes
Checklist: