Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 0.12.1 #698

Merged
merged 8 commits into from
Aug 5, 2023
Merged

feat: 0.12.1 #698

merged 8 commits into from
Aug 5, 2023

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Jul 26, 2023 •
edited
Loading

Motivation and Resolution

starknet 0.12.1 changes

  • Sequencer
  • RPC

Development related changes

Sequencer waitForTransaction options:

type waitForTransactionOptions = {
  retryInterval?: number;
  successStates?: Array<TransactionFinalityStatus | TransactionExecutionStatus>;
  errorStates?: Array<TransactionFinalityStatus | TransactionExecutionStatus>;
};

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

✅ Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit f57e844
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/64ce97f0baba0000088b1081

@tabaktoni tabaktoni changed the title feat: 0.12.1 statuses rework feat: 0.12.1 Jul 31, 2023
@tabaktoni tabaktoni changed the base branch from develop to next-version August 5, 2023 18:42
@tabaktoni tabaktoni marked this pull request as ready for review August 5, 2023 18:43
@tabaktoni
Copy link
Collaborator Author

Unpredictable RPC "Invalid transaction nonce" Issue still present

@tabaktoni tabaktoni merged commit 42120b9 into next-version Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🎉 This PR is included in version 5.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the feat/0.12.1/reverted branch September 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tabaktoni